Fix possible memory leak

php · Sep 27, 2024 · ffb41ea · ffb41ea
1 parent 5f76e86
commit ffb41ea
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/ext/xmlreader/php_xmlreader.c b/ext/xmlreader/php_xmlreader.c
@@ -138,12 +138,19 @@ static int xmlreader_has_property(zend_object *object, zend_string *name, int ty
 			return 0;
 		}
 
+		bool result;
+
 		if (type == ZEND_PROPERTY_NOT_EMPTY) {
-			return zend_is_true(&rv);
+			result = zend_is_true(&rv);
+		} else if (type == ZEND_PROPERTY_ISSET) {
+			result = (Z_TYPE(rv) != IS_NULL);
+		} else {
+			ZEND_UNREACHABLE();
 		}
 
-		ZEND_ASSERT(type == ZEND_PROPERTY_ISSET);
-		return (Z_TYPE(rv) != IS_NULL);
+		zval_ptr_dtor(&rv);
+
+		return result;
 	}
 
 	return zend_std_has_property(object, name, type, cache_slot);