change from review

php · Jan 17, 2025 · 2defed8 · 2defed8
1 parent cbb5147
commit 2defed8
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/ext/intl/converter/converter.c b/ext/intl/converter/converter.c
@@ -376,10 +376,7 @@ static bool php_converter_set_encoding(php_converter_object *objval,
 			/* Should never happen */
 			actual_encoding = "(unknown)";
 		}
-		char *msg;
-		spprintf(&msg, 0, "Ambigious encoding specified, using %s", actual_encoding);
-		intl_error_set(NULL, error, msg, 1);
-		efree(msg);
+		php_error_docref(NULL, E_WARNING, "Ambigious encoding specified, using %s", actual_encoding);
 	} else if (U_FAILURE(error)) {
 		if (objval) {
 			THROW_UFAILURE(objval, "ucnv_open", error);