Add ifdef for NumberFormatter::ROUND_HALFODD

According to the docs, UNUM_ROUND_HALF_ODD is only available since ICU 69.0. The build on Travis currently fails probably because it uses a lower version.
php · Jan 20, 2024 · 117b8de · 117b8de
1 parent 31092c2
commit 117b8de
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/ext/intl/formatter/formatter.stub.php b/ext/intl/formatter/formatter.stub.php
@@ -50,8 +50,10 @@ class NumberFormatter
     public const int ROUND_AWAY_FROM_ZERO = UNKNOWN;
     /** @cvalue UNUM_ROUND_HALFEVEN */
     public const int ROUND_HALFEVEN = UNKNOWN;
+#if U_ICU_VERSION_MAJOR_NUM >= 69
     /** @cvalue UNUM_ROUND_HALF_ODD */
     public const int ROUND_HALFODD = UNKNOWN;
+#endif
     /** @cvalue UNUM_ROUND_HALFDOWN */
     public const int ROUND_HALFDOWN = UNKNOWN;
     /** @cvalue UNUM_ROUND_HALFUP */

diff --git a/ext/intl/formatter/formatter_arginfo.h b/ext/intl/formatter/formatter_arginfo.h
diff --git a/ext/intl/tests/formatter/rounding_modes.phpt b/ext/intl/tests/formatter/rounding_modes.phpt
@@ -2,6 +2,8 @@
 NumberFormatter: rounding modes
 --EXTENSIONS--
 intl
+--SKIPIF--
+<?php if (version_compare(INTL_ICU_VERSION, '69.0') < 0) die('skip for ICU >= 69.0'); ?>
 --FILE--
 <?php
 ini_set("intl.error_level", E_WARNING);