Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not install from composer with Symfony bundle #15

Closed
wants to merge 1 commit into from
Closed

Could not install from composer with Symfony bundle #15

wants to merge 1 commit into from

Conversation

gaetan-petit
Copy link

Update dependencies to allow installing along the latest Symfony bundle.

Fixes: #12

Update dependencies to allow installing along the latest Symfony bundle.

Fixes: #12
@gaetan-petit
Copy link
Author

Looks like there's things that should get fixed. I may look at it later.

@zairigimad
Copy link

this is Useful can this PR be merged :) ?

@welcoMattic
Copy link
Member

New versions of php-translation package has been releases, could you update your PR? So, we will merge it 👍

@gaetan-petit
Copy link
Author

lol @welcoMattic it's been a full year since I opened those PRs.
Franckly nothing worked out of the box and noboby bothered to answer me.
I'll close my PRs, and I advised that you mark this project as unmainted.

@welcoMattic
Copy link
Member

Hi @gaetan-petit, if you look around here, we are back to maintain this project, @Nyholm @odolbeau @bocharsky-bw @rvanlaak me and many other. You are very welcome to bring your help if you want. Be sure that we will take a look more regularly to every repositories of this organization.

@gaetan-petit
Copy link
Author

@welcoMattic Nice to hear. Our main concern was that the adapter is assuming that you are using a fixed patter for translation keys. Which is quite problematic with existing application. see #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not install with composer
3 participants