Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(road-runner): allow ^2023.1.0 and ^2.0 #146

Closed
wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Oct 26, 2023

See #138 /cc @gsdevme

@alexander-schranz
Copy link
Member Author

Looks currently there is a dependency to symfony/console missing not sure if we should add it to require or require-dev as the dependency is not defined by symfony/runtime class where it is used. @Nyholm what do you think?

@alexander-schranz alexander-schranz changed the title "feat(road-runner): allow ^2023.1.0 and ^2.0"" feat(road-runner): allow ^2023.1.0 and ^2.0 Oct 26, 2023
@alexander-schranz alexander-schranz force-pushed the revert-145-revert-138-patch-1 branch from 2a79516 to b82e71d Compare October 26, 2023 23:22
@gsdevme
Copy link
Contributor

gsdevme commented Oct 30, 2023

Yeah its needed in require-dev, I cant push the change though on this branch @alexander-schranz

Problem is the maintainer of roadrunner-server/roadrunner isn't using semver anymore instead using year/month so Im not sure how its best to support.

@alexander-schranz
Copy link
Member Author

@gsdevme you can just open another PR with the required require-dev to the symfony/console.

@alexander-schranz
Copy link
Member Author

alexander-schranz commented Oct 30, 2023

The spiral/roadrunner package seems not longer provide any PHP code since there version changes. The change is roadrunner-server/roadrunner@8d316e5 So I think spiral/roadrunner is not longer the way to go.

Maybe @roxblnfk can help us out what packages we should require here. From first look at I would see we require roadrunner-php/worker ^2 || ^3. But not sure if the cli and worker is also required?

The classes we access are:

$worker = RoadRunner\Worker::create();
$worker = new RoadRunner\Http\PSR7Worker($worker, $this->psrFactory, $this->psrFactory, $this->psrFactory);

$worker = RoadRunner\Worker::create();
$psrFactory = new Psr7\Factory\Psr17Factory();
$worker = new RoadRunner\Http\PSR7Worker($worker, $psrFactory, $psrFactory, $psrFactory);

@rustatian
Copy link

rustatian commented Oct 30, 2023

Hey @alexander-schranz 👋🏻 😃
Yeah, RR is metapackage since v2023.1.0. Currently, spiral\roadrunner-worker, spiral\roadrunner-http and spiral\roadrunner-cli are required. They should be installed manually.

IIRC (my poor PHP knowledge 😢), cli is only required to install RR. If you use only http plugin:

composer require spiral/roadrunner-http nyholm/psr7

@roxblnfk
Copy link

roxblnfk commented Oct 31, 2023

Hi @alexander-schranz
Add spiral/roadrunner only if you are directly tied to any features of the RoadRunner server.

In the code of this package, classes from the following are used directly:

The spiral/roadrunner-cli is helpful to load RoadRunner server binary files using vendor/bin/rr get.

I recommend using the latest versions of the mentioned packages. However, you can try a wider range of versions, excluding spiral/roadrunner:

spiral/roadrunner-http: ^2 || ^3.2
spiral/roadrunner-worker: ^2 || ^3
spiral/roadrunner-cli: ^2

@alexander-schranz
Copy link
Member Author

Thx @roxblnfk, think in our case it does make sense to go with:

spiral/roadrunner-http: ^2 || ^3.2
spiral/roadrunner-worker: ^2 || ^3
spiral/roadrunner-cli: ^2

which was also the previous packages which where installed when using "spiral/roadrunner": "^2.0".

@Nyholm are you fine with that?

@Nyholm
Copy link
Member

Nyholm commented Nov 22, 2023

Yepp. I think that makes sense. Thank you

@davidPaymefy
Copy link

Hi, do we know when this is going to be available? spiral/roadrunner is already on version 2024

@davidPaymefy
Copy link

Hi, do we know when this is going to be available? spiral/roadrunner is already on version 2024

#172

@alexander-schranz
Copy link
Member Author

close in favor of #172

@alexander-schranz alexander-schranz deleted the revert-145-revert-138-patch-1 branch June 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants