-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(road-runner): allow ^2023.1.0 and ^2.0 #146
Conversation
Looks currently there is a dependency to symfony/console missing not sure if we should add it to require or require-dev as the dependency is not defined by |
2a79516
to
b82e71d
Compare
Yeah its needed in Problem is the maintainer of |
@gsdevme you can just open another PR with the required require-dev to the symfony/console. |
The Maybe @roxblnfk can help us out what packages we should require here. From first look at I would see we require The classes we access are: runtime/src/roadrunner-symfony-nyholm/src/Runner.php Lines 35 to 36 in 1c6ac3d
runtime/src/roadrunner-nyholm/src/Runner.php Lines 23 to 25 in 1c6ac3d
|
Hey @alexander-schranz 👋🏻 😃 IIRC (my poor PHP knowledge 😢), composer require spiral/roadrunner-http nyholm/psr7 |
Hi @alexander-schranz ✋ In the code of this package, classes from the following are used directly: The I recommend using the latest versions of the mentioned packages. However, you can try a wider range of versions, excluding
|
Yepp. I think that makes sense. Thank you |
Hi, do we know when this is going to be available? spiral/roadrunner is already on version 2024 |
|
close in favor of #172 |
See #138 /cc @gsdevme