Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): update to v2.0.0 and refactor some project things #33

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

rektdeckard
Copy link
Member

@rektdeckard rektdeckard commented Mar 7, 2023

  • Updates to @phosphor-icons/[email protected] and generates new components
  • Adds support for aliased icon names (some icon were renamed in 2.0, but will continue to also exist under their deprecated names to ease adoption)
  • Adds src to source control
  • Renames some files how I like it
  • Moves from npm to yarn
  • Drastically simplifies the playground so that it does not require any of its own dependencies

@rektdeckard
Copy link
Member Author

Would also like to address #29 and #12 here. And WDYT about making next the default branch @dnlsndr ? I heard Vue2 is approaching end-of-life, but I have no idea what fraction of the community is still using it or has moved to Vue3.

Comment on lines +24 to +35
const ALIASES = {
"file-dashed": "file-dotted",
"file-magnifying-glass": "file-search",
"folder-dashed": "folder-dotted",
"folder-simple-dashed": "folder-simple-dotted",
pulse: "activity",
seal: "circle-wavy",
"seal-check": "circle-wavy-check",
"seal-question": "circle-wavy-question",
"seal-warning": "circle-wavy-warning",
"text-b": "text-bolder",
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to import this directly from core/bin but I couldn't figure out how to get CJS interop working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a bit ugly, but we can still resolve it at some later point

@dnlsndr dnlsndr merged commit 34b0d79 into next Mar 9, 2023
@rektdeckard rektdeckard deleted the next-simplification branch March 9, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants