Update docs mentioning a unique id for an empty state in a stream #3707
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docs do not mention that you need an id when adding an empty state inside the stream DOM element. It is added in the code example.
This PR updates the wording above the example.
Reasoning
When the stream is updated the empty state will be added multiple times if it does not have an id. Therefore the
:only
selector will not work. Makes perfect sense, but it would be good to call it out in the docs.Example
if you forget to add the ID here it will not work
<tbody id="songs" phx-update="stream"> - <tr class="only:block hidden"> + <tr id="songs-empty" class="only:block hidden"> <td colspan="2">No songs found</td> </tr> </tbody>