add scopes to generators #6102
add scopes to generators #6102
Conversation
SteffenDE
force-pushed
the
sd-scope
branch
2 times, most recently
from
3b08167 to
33fbb4c
Compare
integration_test/test/code_generation/app_with_no_options_test.exs
Outdated
Show resolved
Hide resolved
|
|
||
| """ | ||
| def list_<%= schema.plural %>(%<%= inspect scope.alias %>{} = <%= scope.name %>_scope) do | ||
| Repo.all(from <%= schema.singular %> in <%= inspect schema.alias %>, where: <%= schema.singular %>.<%= scope.schema_key %> == ^<%= scope.name %>_scope.<%= Enum.join(scope.access_path, ".") %>) |
There was a problem hiding this comment.
We just added all_by to Ecto. Perhaps we should do a new release?
There was a problem hiding this comment.
Anyway, not the topic of this PR, we can update this and the auth generators to use Repo.transact once Ecto is actually out. I will start working on that front.
SteffenDE
force-pushed
the
sd-scope
branch
2 times, most recently
from
2c4172e to
e5919e6
Compare
apply suggestions from review
guides/scopes.md
Outdated
|
|
||
| > **Requirement**: This guide expects that you have gone through the [introductory guides](installation.html) and got a Phoenix application [up and running](up_and_running.html). | ||
|
|
||
| > **Requirement**: This guide expects that you have gone through the [Contexts guide](contexts.html). |
There was a problem hiding this comment.
Btw, I'd remove those requirements, once we make this more of a reference.
|
Scopes guide updated! |
|
|
||
| ## `on_mount` arguments | ||
|
|
||
| * `:mount_current_<%= schema.singular %>` - Assigns current_<%= schema.singular %> | ||
| * `:mount_current_scope` - Assigns current_scope |
There was a problem hiding this comment.
Shouldn't this mirror fetch_current_scope_for_... and become mount_current_scope_for_...?
There was a problem hiding this comment.
we can change it, but since LV hooks don't have naming conflicts (you always need to pass the module), it's not really an issue
| @@ -229,7 +233,7 @@ defmodule <%= inspect auth_module %> do | |||
| they use the application at all, here would be a good place. | |||
| """ | |||
| def require_authenticated_<%= schema.singular %>(conn, _opts) do | |||
| if conn.assigns[:current_<%= schema.singular %>] do | |||
| if conn.assigns.current_scope do | |||
There was a problem hiding this comment.
We need to check current_user.user here, no? For example, you could have an assigned scope that is for a guest (no user), so feels like this check needs to be more strict
There was a problem hiding this comment.
Agreed on being more precise here in case someone adds more fields to the scope in the future. It doesn’t hurt.
|
💚 💙 💜 💛 ❤️ |
Adds a new concept called "scopes" to the Phoenix generators, as introduced by @chrismccord a while ago:
https://youtu.be/Ckgl9KO4E4M?si=TKgdWCQ87OIPzW_A&t=307
https://github.com/chrismccord/todo_trek/blob/main/lib/todo_trek/scope.ex