add button_classes to CoreComponents #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would personally prefer to avoid new function components. I wonder if we could instead have a function called |
|
Like this? <.link class={button_classes()} href={~p"<%= schema.route_prefix %>/new"}>
New <%= schema.human_singular %>
</.link>Maybe feels weird to have a non-component function imported, but I guess it's fine. |
|
Yes, exactly. If we can share that across places, then it looks good to me! We may need appearance-none. |
|
Changed! I don't think we need appearance-none there, but people may add it if they use it in weird places 😃 |
SteffenDE
changed the title
SteffenDE
force-pushed
the
sd-link-button
branch
from
8391081 to
fdf6cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons and Links must not be nested inside each other, otherwise there are accessibility issues. A previous PR did not fix the problem, but just inverted the problem.
Adds a helper function to return button_classes for styling other components, like links.
Fixes #5770.
Relates to: #5820