Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic tag method #748

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Add dynamic tag method #748

merged 4 commits into from
Sep 2, 2024

Conversation

joeldrapper
Copy link
Collaborator

@joeldrapper joeldrapper commented Aug 12, 2024

Closes #707

This provides a safer alternative to using send and public_send to dynamically call Phlex methods when using your own meta-programming.

@joeldrapper joeldrapper force-pushed the add-dynamic-tag-method branch from fc08e03 to d470721 Compare August 12, 2024 12:32
@joeldrapper joeldrapper force-pushed the add-dynamic-tag-method branch from d470721 to 8959ac0 Compare August 12, 2024 12:33
lib/phlex/sgml.rb Show resolved Hide resolved
lib/phlex/sgml.rb Outdated Show resolved Hide resolved
lib/phlex/sgml.rb Show resolved Hide resolved
Co-authored-by: Stephen Margheim <[email protected]>
Signed-off-by: Joel Drapper <[email protected]>
@joeldrapper joeldrapper marked this pull request as ready for review August 30, 2024 15:14
Copy link
Contributor

@willcosgrove willcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There's one typo in two of the error messages which I left comments on.

lib/phlex/sgml.rb Outdated Show resolved Hide resolved
lib/phlex/sgml.rb Outdated Show resolved Hide resolved
joeldrapper and others added 2 commits September 2, 2024 20:15
Co-authored-by: Will Cosgrove <[email protected]>
Signed-off-by: Joel Drapper <[email protected]>
Co-authored-by: Will Cosgrove <[email protected]>
Signed-off-by: Joel Drapper <[email protected]>
@joeldrapper joeldrapper merged commit 74f8eb6 into main Sep 2, 2024
8 of 11 checks passed
@joeldrapper joeldrapper deleted the add-dynamic-tag-method branch September 2, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a safe dynamic element method
3 participants