Prevent CSV injection attacks #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
Feb 19, 2024
lib/phlex/csv.rb
Outdated
| @@ -82,9 +82,13 @@ def render(renderable) | |||
| end | |||
|
|
|||
| def escape(value) | |||
| value = value.to_s | |||
| value = value.to_s.dup | |||
| value.strip! | |||
There was a problem hiding this comment.
This should be optional. Perhaps you should be able to define def strip_values? = false or something like that.
joeldrapper
commented
Feb 20, 2024
joeldrapper
commented
Feb 20, 2024
Comment on lines
-64
to
+71
| def collection_yielder(record) | ||
| def yielder(record) |
There was a problem hiding this comment.
Unrelated to the main purpose of this PR, I think I prefer yielder for this method, since it's not really yielding the collection, it's really yielding a single item in the collection.
joeldrapper
commented
Feb 20, 2024
lib/phlex/csv.rb
Outdated
Comment on lines
21
to
23
| unless prevent_csv_injection? == true || prevent_csv_injection? == false | ||
| raise "You must define `prevent_csv_injection?` on #{self.class.inspect}, returning `true` or `false`. See https://owasp.org/www-community/attacks/CSV_Injection" | ||
| end |
There was a problem hiding this comment.
By settings prevent_csv_injection? to nil by default, we can force the developer to make an informed decision upfront by raising here. The developer must choose whether to enable or disable the protection, and they have an opportunity to learn about the risk on owasp.org.
joeldrapper
commented
Feb 20, 2024
joeldrapper
commented
Feb 20, 2024
joeldrapper
commented
Feb 20, 2024
joeldrapper
commented
Feb 20, 2024
joeldrapper
commented
Feb 20, 2024
This reverts commit c48c915.
joeldrapper
force-pushed
the
prevent-csv-injection-attacks
branch
from
2a71eb8 to
8f22b1d
Compare
willcosgrove
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661 and also closes #659.
Todo