Fix an attribute serialization bug when using nested attributes with …

…symbol values
phlex-ruby · Sep 7, 2024 · 425e555 · 425e555
1 parent ceffded
commit 425e555
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/phlex/sgml.rb b/lib/phlex/sgml.rb
@@ -514,7 +514,7 @@ def __nested_attributes__(attributes, base_name, buffer = +"")
 			when String
 				buffer << " " << base_name << name << '="' << v.gsub('"', "&quot;") << '"'
 			when Symbol
-				buffer << " " << name << '="' << v.name.tr("_", "-").gsub('"', "&quot;") << '"'
+				buffer << " " << base_name << name << '="' << v.name.tr("_", "-").gsub('"', "&quot;") << '"'
 			when Integer, Float
 				buffer << " " << base_name << name << '="' << v.to_s << '"'
 			when Hash

diff --git a/quickdraw/sgml/attributes.test.rb b/quickdraw/sgml/attributes.test.rb
@@ -40,4 +40,14 @@
 
 		expect(example.call) == %(<#{tag} style="color:red;font-weight:bold;">content</#{tag}>)
 	end
+
+	test "<#{tag}> with data attributes" do
+		example = Class.new(Phlex::HTML) do
+			define_method :view_template do
+				__send__(method_name, data: { controller: "foo", turbo_action: :delete }) { "content" }
+			end
+		end
+
+		expect(example.call) == %(<#{tag} data-controller="foo" data-turbo-action="delete">content</#{tag}>)
+	end
 end