Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gatt server support bitwise and permissions #492

Closed
wants to merge 7 commits into from

Conversation

EkelmansPh
Copy link
Contributor

No description provided.

magi-arun and others added 6 commits November 20, 2023 14:37
* feat: add order to pack upg supported targets

* resolve review comments

* refactor: resolved review comments

* refactor: resolved review comments

* style: fix build

* refactor: resolved review comments

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* review comments resolved

* build(deps): bump github/codeql-action from 2.21.6 to 2.21.7 (#417)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.6 to 2.21.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@701f152...04daf01)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: consolidate configurations (#411)

* ci: consolidate configurations

* Change Package config into Host-Single-MinSizeRel, split Windows/MacOS workflows

* Add Host-Single-Debug, use for MacOS ci

* Disable sccache for Windows build

* Consolidate Windows and MacOS builds

* Explicitly enable tests

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Use the correct configuration for the test preset

* Presets now start with a lower case character

* Presets now start with a lower case character

* Presets now start with a lower case character

* Update CMakePresets.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* .github/workflows/ci.yml: small improvements

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): bump actions/checkout from 4.0.0 to 4.1.0 (#420)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@3df4ab1...8ade135)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/first-interaction from 1.1.1 to 1.2.0 (#421)

Bumps [actions/first-interaction](https://github.com/actions/first-interaction) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/actions/first-interaction/releases)
- [Commits](actions/first-interaction@1d8459c...1dbfe1b)

---
updated-dependencies:
- dependency-name: actions/first-interaction
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github/codeql-action from 2.21.7 to 2.21.9 (#422)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.7 to 2.21.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@04daf01...ddccb87)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: switch static analysis to container (#423)

* chore: update devcontainer

* chore: switch static analysis to container

* chore: use correct configurations

* chore: remove workaround for missing symlinks

When running into issues using mutation testing, please update your local devcontainer.

* chore: use correct mutation-testing preset

* chore: update CMakePresets.json

* chore: update googletest

* chore: use nproc for -j parameters

* chore: revert version update in CMakePresets.json

* deps: update mbedtls to 3.4.1 to silence warning

See: Mbed-TLS/mbedtls#7098

* chore: fix compilation with clang-15

* chore: fix remaining issues

* build(deps): bump oxsecurity/megalinter from 7.3.0 to 7.4.0 (#419)

* build(deps): bump oxsecurity/megalinter from 7.3.0 to 7.4.0

Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7.3.0 to 7.4.0.
- [Release notes](https://github.com/oxsecurity/megalinter/releases)
- [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md)
- [Commits](oxsecurity/megalinter@fda6ac3...a87b287)

---
updated-dependencies:
- dependency-name: oxsecurity/megalinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: fix linter findings

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ron <[email protected]>

* feat: add protobuf/echo/ProtoMessageBuilder (#416)

* feat: add protobuf/echo/ProtoMessageBuilder

* ProtoCEchoPlugin: Fix superfluous typename

* protobuf/echoProtoMessageBuilder: Parse a lot of different types

* protobuf/echoProtoMessageBuilder: Parse enums, strings, extract BuferingStreamReader

* Resolve code warnings, increase coverage

* protobuf/echo: Add BufferingStreamWriter

* protobuf/echo: Add half of ProtoMessageSender

* protobuf/echo/ProtoMessageSender: Serialize lots of types

* protobuf/echo/ProtoMessageSender: Fix missing template keyword

* protobuf/echo/ProtoMessageSender: Serialize lots of types

* protobuf/protoc_echo_plugin/ProtoCEchoPlugin: Modify result of MessageReference::Get() const to avoid a warning

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* protobuf/echo/BufferingStreamReader: Make BufferingStreamReader accept a stream reader instead of a byte range

* protobuf/echo/BufferingStreamReader: Remove useless comment

* Resolve Sonar warnings

* Resolve Sonar warnings

* Move BufferingSteamReader and BufferingStreamWriter to infra/stream

* infra/stream/test: Add tests for BufferingStreamReader and BufferingStreamWriter

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Resolve Sonar warnings

* Resolve Sonar warnings

* Resolve Sonar warnings

* Reduce duplication

* Update services/network/test_doubles/Certificates.cpp

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ron <[email protected]>

* build(deps): bump google-github-actions/release-please-action from 3.7.11 to 3.7.12 (#426)

build(deps): bump google-github-actions/release-please-action

Bumps [google-github-actions/release-please-action](https://github.com/google-github-actions/release-please-action) from 3.7.11 to 3.7.12.
- [Release notes](https://github.com/google-github-actions/release-please-action/releases)
- [Changelog](https://github.com/google-github-actions/release-please-action/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/release-please-action@ca6063f...4c5670f)

---
updated-dependencies:
- dependency-name: google-github-actions/release-please-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump oss-fuzz-base/base-builder from `5e1404d` to `6c61e46` in /.clusterfuzzlite (#427)

build(deps): bump oss-fuzz-base/base-builder in /.clusterfuzzlite

Bumps oss-fuzz-base/base-builder from `5e1404d` to `6c61e46`.

---
updated-dependencies:
- dependency-name: oss-fuzz-base/base-builder
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: add emil_install to emil_build_for.cmake which only installs the target if it is part of the All target (#425)

(cherry picked from commit b669983)

* build(deps): bump seanmiddleditch/gha-setup-ninja from 3 to 4 (#430)

Bumps [seanmiddleditch/gha-setup-ninja](https://github.com/seanmiddleditch/gha-setup-ninja) from 3 to 4.
- [Release notes](https://github.com/seanmiddleditch/gha-setup-ninja/releases)
- [Commits](seanmiddleditch/gha-setup-ninja@16b9408...8b29707)

---
updated-dependencies:
- dependency-name: seanmiddleditch/gha-setup-ninja
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (#432)

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@08b4669...483ef80)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github/codeql-action from 2.21.9 to 2.22.1 (#433)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.9 to 2.22.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ddccb87...fdcae64)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: make services/util/MessageCommunicationSecured compliant with MbedTLS version 2 (#434)

* chore: make services/util/MessageCommunicationSecured compliant with MbedTLS version 2

* services/util/MessageCommunicationSecured: Include mbedtls/version.h

* build(deps): bump github/codeql-action from 2.22.1 to 2.22.3 (#437)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.1 to 2.22.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@fdcae64...0116bc2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/checkout from 4.1.0 to 4.1.1 (#438)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8ade135...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: removed Dac.hpp (#439)

* feat: added SerialCommunicationLoopback (#440)

* feat: added SerialCommunicationLoopback

* chore: replaced ClockFixture with EventDispatcherFixture

* chore: made SerialCommunicationLoopback compatible with <= GCC9

* chore: fixed comments

* chore: correct comparing byte ranges for SerialCommunicationLoopbackTest

* chore: fix coverage and macos build

---------

Co-authored-by: Daan Timmer <[email protected]>

* fix: added workaround mbedtls and clang-cl incomatibility (#441)

* fix: added workaround by replacing CMAKE_C_COMPILER_ID with CMAKE_C_SIMULATE_ID when configuring mbedtls

* chore: reworked comment and removed references to xwin

* build(deps): bump Namchee/conventional-pr from 0.14.0 to 0.14.1 (#443)

Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.0 to 0.14.1.
- [Release notes](https://github.com/namchee/conventional-pr/releases)
- [Commits](Namchee/conventional-pr@5d1221f...cc86d48)

---
updated-dependencies:
- dependency-name: Namchee/conventional-pr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (#444)

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@483ef80...0864cf1)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github/codeql-action from 2.22.3 to 2.22.4 (#442)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.3 to 2.22.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@0116bc2...49abf0b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: only build and install protobuf echo compilers when EMIL_BUILD_ECHO_COMPILERS is set (#445)

* build: only build and install protobuf echo compilers when EMIL_BUILD_ECHO_COMPILERS is set

* protobuf/protoc_echo_plugin*/CMakeLists: Fix emil_build_for statement

* Install export file, but only whene EMIL_BUILD_ECHO_COMPILERS

* build(deps): bump oxsecurity/megalinter from 7.4.0 to 7.5.0 (#446)

Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7.4.0 to 7.5.0.
- [Release notes](https://github.com/oxsecurity/megalinter/releases)
- [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md)
- [Commits](oxsecurity/megalinter@a87b287...b48455a)

---
updated-dependencies:
- dependency-name: oxsecurity/megalinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github/codeql-action from 2.22.4 to 2.22.5 (#447)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.4 to 2.22.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@49abf0b...74483a3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump Namchee/conventional-pr from 0.14.1 to 0.15.1 (#448)

Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.1 to 0.15.1.
- [Release notes](https://github.com/namchee/conventional-pr/releases)
- [Commits](Namchee/conventional-pr@cc86d48...93f5107)

---
updated-dependencies:
- dependency-name: Namchee/conventional-pr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump carlosperate/arm-none-eabi-gcc-action from 1.7.1 to 1.8.0 (#449)

build(deps): bump carlosperate/arm-none-eabi-gcc-action

Bumps [carlosperate/arm-none-eabi-gcc-action](https://github.com/carlosperate/arm-none-eabi-gcc-action) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/carlosperate/arm-none-eabi-gcc-action/releases)
- [Changelog](https://github.com/carlosperate/arm-none-eabi-gcc-action/blob/main/CHANGELOG.md)
- [Commits](carlosperate/arm-none-eabi-gcc-action@6a221d7...e9cd61b)

---
updated-dependencies:
- dependency-name: carlosperate/arm-none-eabi-gcc-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix review comments

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: Richard Peters <[email protected]>

* refactor: fix review comments

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Richard Peters <[email protected]>
Co-authored-by: Ron <[email protected]>
Co-authored-by: Daan Timmer <[email protected]>
Co-authored-by: Daan Timmer <[email protected]>
* Add tracing with switch and level

* Discard all tracing code when tracing is off

* Make Tracer::Trace() non virtual
* build(deps): bump github/codeql-action from 2.21.6 to 2.21.7 (#417)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.6 to 2.21.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@701f152...04daf01)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: consolidate configurations (#411)

* ci: consolidate configurations

* Change Package config into Host-Single-MinSizeRel, split Windows/MacOS workflows

* Add Host-Single-Debug, use for MacOS ci

* Disable sccache for Windows build

* Consolidate Windows and MacOS builds

* Explicitly enable tests

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Use the correct configuration for the test preset

* Presets now start with a lower case character

* Presets now start with a lower case character

* Presets now start with a lower case character

* Update CMakePresets.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* .github/workflows/ci.yml: small improvements

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): bump actions/checkout from 4.0.0 to 4.1.0 (#420)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@3df4ab1...8ade135)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/first-interaction from 1.1.1 to 1.2.0 (#421)

Bumps [actions/first-interaction](https://github.com/actions/first-interaction) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/actions/first-interaction/releases)
- [Commits](actions/first-interaction@1d8459c...1dbfe1b)

---
updated-dependencies:
- dependency-name: actions/first-interaction
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github/codeql-action from 2.21.7 to 2.21.9 (#422)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.7 to 2.21.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@04daf01...ddccb87)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: switch static analysis to container (#423)

* chore: update devcontainer

* chore: switch static analysis to container

* chore: use correct configurations

* chore: remove workaround for missing symlinks

When running into issues using mutation testing, please update your local devcontainer.

* chore: use correct mutation-testing preset

* chore: update CMakePresets.json

* chore: update googletest

* chore: use nproc for -j parameters

* chore: revert version update in CMakePresets.json

* deps: update mbedtls to 3.4.1 to silence warning

See: Mbed-TLS/mbedtls#7098

* chore: fix compilation with clang-15

* chore: fix remaining issues

* feat: add order to pack upg supported targets

* resolve review comments

* refactor: resolved review comments

* refactor: resolved review comments

* style: fix build

* refactor: resolved review comments

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* review comments resolved

* fix review comments

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp

Co-authored-by: Richard Peters <[email protected]>

* refactor: fix review comments

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Richard Peters <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ron <[email protected]>
* feat!: moved Gap.proto to services.ble and added Gatt.proto

* feat: added AttAttribute UUIDs for common gatt attributes

* chore: replaced constexpr static with constexpr inline in Gatt.hpp

---------

Co-authored-by: Timmer, Daan <[email protected]>
@EkelmansPh EkelmansPh requested a review from a team as a code owner December 7, 2023 15:11
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Dec 7, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.1s
✅ DOCKERFILE hadolint 2 0 0.19s
✅ JSON eslint-plugin-jsonc 8 0 0 4.44s
✅ JSON jsonlint 8 0 0.13s
✅ JSON prettier 8 0 0 0.62s
✅ MARKDOWN markdownlint 5 1 0 1.3s
⚠️ MARKDOWN markdown-link-check 5 3 75.95s
✅ MARKDOWN markdown-table-formatter 5 1 0 0.35s
✅ REPOSITORY checkov yes no 24.69s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 18.02s
✅ REPOSITORY secretlint yes no 6.43s
✅ REPOSITORY syft yes no 0.28s
✅ REPOSITORY trivy yes no 13.21s
✅ REPOSITORY trivy-sbom yes no 0.86s
✅ REPOSITORY trufflehog yes no 4.3s
⚠️ SPELL lychee 125 2 3.49s
⚠️ YAML prettier 22 0 1 1.24s
✅ YAML v8r 22 0 10.91s
✅ YAML yamllint 22 0 0.32s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@EkelmansPh EkelmansPh closed this Dec 11, 2023
@EkelmansPh EkelmansPh deleted the feature/gatt_server_permission_bitwise_and branch December 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants