cleanup and address SQ issue

philips-software · Feb 7, 2025 · a10ec51 · a10ec51
1 parent cdab43a
commit a10ec51
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/services/network/HttpClientImpl.cpp b/services/network/HttpClientImpl.cpp
@@ -355,13 +355,6 @@ namespace services
         ConnectionObserver::Subject().RequestSendStream(request->Size());
     }
 
-    uint32_t HttpClientImpl::ReadContentSizeFromObserver() const
-    {
-        infra::DataOutputStream::WithWriter<infra::CountingStreamWriter> stream;
-        Observer().FillContent(stream.Writer());
-        return stream.Writer().Processed();
-    }
-
     void HttpClientImpl::AbortAndDestroy()
     {
         ConnectionObserver::Subject().AbortAndDestroy();
@@ -487,7 +480,7 @@ namespace services
 
     void HttpClientImpl::SendingStateForwardFillContent::SendStreamAvailable(infra::SharedPtr<infra::StreamWriter>&& writer)
     {
-        infra::LimitedStreamWriter limitedWriter(*writer, std::min(contentSize, writer->Available()));
+        infra::LimitedStreamWriter limitedWriter(*writer, std::min<std::size_t>(contentSize, writer->Available()));
         auto marker = limitedWriter.ConstructSaveMarker();
         client.Observer().FillContent(limitedWriter);
         contentSize -= limitedWriter.GetProcessedBytesSince(marker);

diff --git a/services/network/HttpClientImpl.hpp b/services/network/HttpClientImpl.hpp
@@ -70,7 +70,6 @@ namespace services
         void ExecuteRequestWithContent(HttpVerb verb, infra::BoundedConstString requestTarget, infra::BoundedConstString content, const HttpHeaders headers);
         void ExecuteRequestWithContent(HttpVerb verb, infra::BoundedConstString requestTarget, const HttpHeaders headers);
         void ExecuteRequestWithContent(HttpVerb verb, infra::BoundedConstString requestTarget, std::size_t contentSize, const HttpHeaders headers);
-        uint32_t ReadContentSizeFromObserver() const;
         void AbortAndDestroy();
 
     private: