Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update googletest to the latest released version #608

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rjaegers
Copy link
Member

Pull Request

Description of changes

This PR updates Googletest used in the tests to version 1.15.2.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 19, 2024 14:35
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:cd0e2aee8ccf95eefc44cf9c351891d0a9f661c984ea71187909e635714b33d3

OS/Platform Previous Size Current Size Delta
linux/amd64 425.13M 433.00M 7.87M (+1.85%)
linux/arm64 564.77M 572.52M 7.75M (+1.37%)

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:e0f70233d2f52850da5d6883b15e9a80d916ffc6472c18e84da8cb2c1d7f257b

OS/Platform Previous Size Current Size Delta
linux/amd64 645.35M 645.35M 0.00 (+0.00%)
linux/arm64 638.06M 638.06M 0.00 (+0.00%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.1s
✅ DOCKERFILE hadolint 2 0 0.43s
✅ GHERKIN gherkin-lint 2 0 0.69s
✅ JSON npm-package-json-lint yes no 0.43s
✅ JSON prettier 15 2 0 0.67s
✅ JSON v8r 14 0 22.64s
✅ MARKDOWN markdownlint 8 0 0 1.02s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.27s
✅ REPOSITORY checkov yes no 14.97s
✅ REPOSITORY gitleaks yes no 0.32s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.94s
✅ REPOSITORY secretlint yes no 1.57s
✅ REPOSITORY syft yes no 0.56s
✅ REPOSITORY trivy yes no 5.45s
✅ REPOSITORY trivy-sbom yes no 0.19s
✅ REPOSITORY trufflehog yes no 2.22s
✅ SPELL lychee 54 0 0.96s
✅ YAML prettier 21 0 0 1.15s
✅ YAML v8r 21 0 16.55s
✅ YAML yamllint 21 0 0.33s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   52s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 847794e. ± Comparison against base commit 94025e9.

@rjaegers rjaegers enabled auto-merge October 19, 2024 14:47
@rjaegers rjaegers added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 866a1c9 Oct 21, 2024
21 checks passed
@rjaegers rjaegers deleted the feature/update-googletest branch October 21, 2024 07:17
Copy link
Contributor

Pull Request Report (#608)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 1
Number of changed files 1
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.7 Days
Time that was spend on the branch before the PR was created 1.4 Min
Time that was spend on the branch before the PR was merged 1.7 Days
Time to merge after last review 3.7 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 22.3 Min
Total time spend in last status check run on PR 10.6 Min

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants