Composer: Install & configure Rector and fix all errors

.github/workflows/backend.yml

@@ -50,6 +50,24 @@ jobs:
       - name: Run phpstan
         run: composer run phpstan
 
+  rector:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.3'
+      - uses: actions/checkout@v4
+      - name: Copy .env
+        run: php -r "file_exists('.env') || copy('.env.example', '.env');"
+      - name: Install Dependencies
+        run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist
+      - name: Generate key
+        run: php artisan key:generate
+      - name: Directory Permissions
+        run: chmod -R 777 storage bootstrap/cache
+      - name: Run rector
+        run: composer run rector -- --dry-run
+
   php-cs-fixer:
     runs-on: ubuntu-latest
     steps:

README.md

@@ -27,6 +27,7 @@ Back end:
 * Laravel 10
 * PHPStan (& Larastan) set to the highest level, as well as phpstan/phpstan-strict-rules for extra strictness
 * PHPUnit 10
+* Rector
 * PHP CS Fixer configured to use the latest PER coding standards
 * PHP_CodeSniffer configured to use the latest PSR12 coding standards
 

app/Console/Kernel.php

@@ -6,12 +6,14 @@
 
 use Illuminate\Console\Scheduling\Schedule;
 use Illuminate\Foundation\Console\Kernel as ConsoleKernel;
+use Override;
 
-class Kernel extends ConsoleKernel
+final class Kernel extends ConsoleKernel
 {
     /**
      * Define the application's command schedule.
      */
+    #[Override]
     protected function schedule(Schedule $schedule): void
     {
         // $schedule->command('inspire')->hourly();
@@ -20,6 +22,7 @@ protected function schedule(Schedule $schedule): void
     /**
      * Register the commands for the application.
      */
+    #[Override]
     protected function commands(): void
     {
         $this->load(__DIR__ . '/Commands');

app/Exceptions/Handler.php

@@ -5,9 +5,10 @@
 namespace App\Exceptions;
 
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Override;
 use Throwable;
 
-class Handler extends ExceptionHandler
+final class Handler extends ExceptionHandler
 {
     /**
      * The list of the inputs that are never flashed to the session on validation exceptions.
@@ -23,6 +24,7 @@ class Handler extends ExceptionHandler
     /**
      * Register the exception handling callbacks for the application.
      */
+    #[Override]
     public function register(): void
     {
         $this->reportable(static function (Throwable $e): void {

app/Http/Controllers/Controller.php

@@ -8,7 +8,7 @@
 use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Routing\Controller as BaseController;
 
-class Controller extends BaseController
+final class Controller extends BaseController
 {
     use AuthorizesRequests;
     use ValidatesRequests;

app/Http/Kernel.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Foundation\Http\Kernel as HttpKernel;
 
-class Kernel extends HttpKernel
+final class Kernel extends HttpKernel
 {
     /**
      * The application's global HTTP middleware stack.

app/Http/Middleware/Authenticate.php

@@ -6,12 +6,14 @@
 
 use Illuminate\Auth\Middleware\Authenticate as Middleware;
 use Illuminate\Http\Request;
+use Override;
 
-class Authenticate extends Middleware
+final class Authenticate extends Middleware
 {
     /**
      * Get the path the user should be redirected to when they are not authenticated.
      */
+    #[Override]
     protected function redirectTo(Request $request): ?string
     {
         return $request->expectsJson() ? null : \route('login');

app/Http/Middleware/EncryptCookies.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Cookie\Middleware\EncryptCookies as Middleware;
 
-class EncryptCookies extends Middleware
+final class EncryptCookies extends Middleware
 {
     /**
      * The names of the cookies that should not be encrypted.

app/Http/Middleware/PreventRequestsDuringMaintenance.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance as Middleware;
 
-class PreventRequestsDuringMaintenance extends Middleware
+final class PreventRequestsDuringMaintenance extends Middleware
 {
     /**
      * The URIs that should be reachable while maintenance mode is enabled.

app/Http/Middleware/RedirectIfAuthenticated.php

@@ -10,7 +10,7 @@
 use Illuminate\Support\Facades\Auth;
 use Symfony\Component\HttpFoundation\Response;
 
-class RedirectIfAuthenticated
+final class RedirectIfAuthenticated
 {
     /**
      * Handle an incoming request.

app/Http/Middleware/TrimStrings.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Foundation\Http\Middleware\TrimStrings as Middleware;
 
-class TrimStrings extends Middleware
+final class TrimStrings extends Middleware
 {
     /**
      * The names of the attributes that should not be trimmed.

app/Http/Middleware/TrustHosts.php

@@ -5,14 +5,16 @@
 namespace App\Http\Middleware;
 
 use Illuminate\Http\Middleware\TrustHosts as Middleware;
+use Override;
 
-class TrustHosts extends Middleware
+final class TrustHosts extends Middleware
 {
     /**
      * Get the host patterns that should be trusted.
      *
      * @return array<int, string|null>
      */
+    #[Override]
     public function hosts(): array
     {
         return [

app/Http/Middleware/TrustProxies.php

@@ -7,7 +7,7 @@
 use Illuminate\Http\Middleware\TrustProxies as Middleware;
 use Illuminate\Http\Request;
 
-class TrustProxies extends Middleware
+final class TrustProxies extends Middleware
 {
     /**
      * The trusted proxies for this application.

app/Http/Middleware/ValidateSignature.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Routing\Middleware\ValidateSignature as Middleware;
 
-class ValidateSignature extends Middleware
+final class ValidateSignature extends Middleware
 {
     /**
      * The names of the query string parameters that should be ignored.

app/Http/Middleware/VerifyCsrfToken.php

@@ -6,7 +6,7 @@
 
 use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken as Middleware;
 
-class VerifyCsrfToken extends Middleware
+final class VerifyCsrfToken extends Middleware
 {
     /**
      * The URIs that should be excluded from CSRF verification.

app/Models/User.php

@@ -10,7 +10,7 @@
 use Illuminate\Notifications\Notifiable;
 use Laravel\Sanctum\HasApiTokens;
 
-class User extends Authenticatable
+final class User extends Authenticatable
 {
     use HasApiTokens;
     use HasFactory;

app/Providers/AppServiceProvider.php

@@ -9,12 +9,14 @@
 use Illuminate\Support\ServiceProvider;
 use Illuminate\Translation\Translator;
 use OutOfBoundsException;
+use Override;
 
-class AppServiceProvider extends ServiceProvider
+final class AppServiceProvider extends ServiceProvider
 {
     /**
      * Register any application services.
      */
+    #[Override]
     public function register(): void
     {
         $this->app->resolving('translator', function (Translator $translator): void {

app/Providers/AuthServiceProvider.php

@@ -7,7 +7,7 @@
 // use Illuminate\Support\Facades\Gate;
 use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;
 
-class AuthServiceProvider extends ServiceProvider
+final class AuthServiceProvider extends ServiceProvider
 {
     /**
      * The model to policy mappings for the application.

app/Providers/BroadcastServiceProvider.php

@@ -7,7 +7,7 @@
 use Illuminate\Support\Facades\Broadcast;
 use Illuminate\Support\ServiceProvider;
 
-class BroadcastServiceProvider extends ServiceProvider
+final class BroadcastServiceProvider extends ServiceProvider
 {
     /**
      * Bootstrap any application services.

app/Providers/EventServiceProvider.php

@@ -8,8 +8,9 @@
 use Illuminate\Auth\Listeners\SendEmailVerificationNotification;
 use Illuminate\Foundation\Support\Providers\EventServiceProvider as ServiceProvider;
 use Illuminate\Support\Facades\Event;
+use Override;
 
-class EventServiceProvider extends ServiceProvider
+final class EventServiceProvider extends ServiceProvider
 {
     /**
      * The event to listener mappings for the application.
@@ -25,6 +26,7 @@ class EventServiceProvider extends ServiceProvider
     /**
      * Register any events for your application.
      */
+    #[Override]
     public function boot(): void
     {
         //
@@ -33,6 +35,7 @@ public function boot(): void
     /**
      * Determine if events and listeners should be automatically discovered.
      */
+    #[Override]
     public function shouldDiscoverEvents(): bool
     {
         return false;

app/Providers/RouteServiceProvider.php

@@ -9,8 +9,9 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\RateLimiter;
 use Illuminate\Support\Facades\Route;
+use Override;
 
-class RouteServiceProvider extends ServiceProvider
+final class RouteServiceProvider extends ServiceProvider
 {
     /**
      * The path to your application's "home" route.
@@ -19,11 +20,12 @@ class RouteServiceProvider extends ServiceProvider
      *
      * @var string
      */
-    public const HOME = '/home';
+    final public const string HOME = '/home';
 
     /**
      * Define your route model bindings, pattern filters, and other route configuration.
      */
+    #[Override]
     public function boot(): void
     {
         RateLimiter::for(

composer.json

@@ -13,6 +13,7 @@
         "laravel/tinker": "^2.8"
     },
     "require-dev": {
+        "driftingly/rector-laravel": "^0.30.0",
         "fakerphp/faker": "^1.9.1",
         "friendsofphp/php-cs-fixer": "^3.47",
         "larastan/larastan": "^2.8",
@@ -23,6 +24,7 @@
         "phpstan/phpstan-phpunit": "^1.3",
         "phpstan/phpstan-strict-rules": "^1.5",
         "phpunit/phpunit": "^10.1",
+        "rector/rector": "^0.19.2",
         "spatie/laravel-ignition": "^2.0",
         "squizlabs/php_codesniffer": "^3.8"
     },
@@ -74,6 +76,9 @@
         "phpstan": [
             "phpstan --ansi"
         ],
+        "rector": [
+            "rector process --ansi"
+        ],
         "php-cs-fixer": [
             "php-cs-fixer fix --ansi"
         ],