Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a keyboard shortcut for exporting #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jneidel
Copy link

@jneidel jneidel commented Aug 23, 2024

Since the save keyboard shortcut is currently not implemented (see below), this introduces ^e as a shortcut for faster keyboard driven interactions.

private void do_save() {

    /* TBD */

}

Copy link
Owner

@phase1geo phase1geo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch isn't going to work properly as the do_export takes two arguments, but using a keyboard shortcut in the given manner is only going to do what you are expecting it to.

What is the expected behavior when the user uses the keyboard shortcut Control-E? Is this just going to display the export menu (same as clicking the export button in the header) and given the dropdown menu focus? Or are you expecting the last selected export type/options to be applied on the current image? The desired effect will need to be coded as such.

Additionally, keyboard shortcuts are recorded in the data/com.github.phase1geo.annotator.shortcuts.ui file so that the user can see them when using the keyboard shortcut cheatsheet. I also like to add the keyboard shortcut within a tooltip using the Utils.tooltip_with_accel() function -- one should be added to the export header button tooltip.

If you are willing to add these changes, I can approve the pull request.

@phase1geo phase1geo added the enhancement New feature or request label Aug 23, 2024
@phase1geo phase1geo added this to the 1.3.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants