Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused 'View-Repository-HiedraAlt' tag #1881

Closed

Conversation

tinchodias
Copy link
Collaborator

This is a clean up and fixes #1878

@Ducasse
Copy link
Collaborator

Ducasse commented Jan 20, 2025

Hi martin

do you know if these two tests are related?

IceTipRepositoryBrowserWithRemoteTest
 ✗ #testHasHiedraHistoryBrowser (169ms)
UndeclaredVariableRead: Attempt to read undeclared variable IceTipHiedraAltHistoryBrowser
UndeclaredVariable>>runtimeUndeclaredReadInContext:
IceTipRepositoryBrowserWithRemoteTest(IceTipRepositoryBrowserTest)>>testHasHiedraHistoryBrowser ...IceTipHiedraAltHistoryBrowser
IceTipRepositoryBrowserWithRemoteTest(TestCase)>>performTest

IceTipRepositoryBrowserWithoutRemoteTest
 ✗ #testHasHiedraHistoryBrowser (265ms)
UndeclaredVariableRead: Attempt to read undeclared variable IceTipHiedraAltHistoryBrowser
UndeclaredVariable>>runtimeUndeclaredReadInContext:
IceTipRepositoryBrowserWithoutRemoteTest(IceTipRepositoryBrowserTest)>>testHasHiedraHistoryBrowser ...IceTipHiedraAltHistoryBrowser
IceTipRepositoryBrowserWithoutRemoteTest(TestCase)>>performTest

@tinchodias
Copy link
Collaborator Author

@Ducasse yes they are related. I'll check if we have to just remove the test, or replace the reference to the "Alt" (removed) class name by new name. Because the hiedra view is still active, of course.

@tinchodias
Copy link
Collaborator Author

I fixed the test (a bit strange test anyway, it only checks that there is a presenter with certain class).

@tinchodias
Copy link
Collaborator Author

@Ducasse this time the tests seem unrelated

@Ducasse
Copy link
Collaborator

Ducasse commented Jan 28, 2025

Argh I probably redid it too :(

@Ducasse Ducasse closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hiedraColumnController is invoked with dead code formAtRow:
2 participants