Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo of PR #1873 #1880

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Redo of PR #1873 #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d14ec16
Revert "Merge pull request #1879 from pharo-vcs/revert-1873-ResizeWin…
jecisc Jan 14, 2025
7d476c2
FIx class names
jecisc Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Iceberg-Plugin-GitHub/IceGitHubAcceptPullRequestPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ Class {
#tag : 'View'
}

{ #category : 'accessing' }
IceGitHubAcceptPullRequestPresenter class >> defaultPreferredExtent [
^ (600 @ 300)
]

{ #category : 'class initialization' }
IceGitHubAcceptPullRequestPresenter class >> initialize [

Expand Down Expand Up @@ -62,12 +67,6 @@ IceGitHubAcceptPullRequestPresenter >> defaultType [
^ 'merge'
]

{ #category : 'api' }
IceGitHubAcceptPullRequestPresenter >> initialExtentForWindow [

^ (600 @ 300) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceGitHubAcceptPullRequestPresenter >> initializeDialogWindow: aDialogWindowPresenter [

Expand Down
13 changes: 6 additions & 7 deletions Iceberg-Plugin-GitHub/IceGitHubCreatePullRequestPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ Class {
#tag : 'View'
}

{ #category : 'accessing' }
IceGitHubCreatePullRequestPresenter class >> defaultPreferredExtent [
^ (700 @ 300)
]

{ #category : 'class initialization' }
IceGitHubCreatePullRequestPresenter class >> initialize [

Expand Down Expand Up @@ -251,13 +256,7 @@ IceGitHubCreatePullRequestPresenter >> headRemote [
]

{ #category : 'initialization' }
IceGitHubCreatePullRequestPresenter >> initialExtentForWindow [

^ (700 @ 300) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceGitHubCreatePullRequestPresenter >> initializeDialogWindow: aWindow [
IceGitHubCreatePullRequestModel >> initializeDialogWindow: aWindow [

aWindow
addButton: 'Cancel' do: [ :presenter |
Expand Down
13 changes: 7 additions & 6 deletions Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ Class {
#tag : 'View'
}

{ #category : 'accessing' }
IceGitHubNewBranchFromIssuePanel class >> defaultPreferredExtent [


^ 800 @ 175
]

{ #category : 'accessing' }
IceGitHubNewBranchFromIssuePanel >> branchName [

Expand Down Expand Up @@ -56,12 +63,6 @@ IceGitHubNewBranchFromIssuePanel >> icon [
^ (self iconNamed: #github) scaledToSize: 16@16
]

{ #category : 'initialization' }
IceGitHubNewBranchFromIssuePanel >> initialExtentForWindow [

^ 800 @ 175
]

{ #category : 'initialization' }
IceGitHubNewBranchFromIssuePanel >> initialize [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-Plugin-GitHub/IceGitHubRejectPullRequestPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Class {
#tag : 'View'
}

{ #category : 'accessing' }
IceGitHubRejectPullRequestPresenter class >> defaultPreferredExtent [
^ (500 @ 250)
]

{ #category : 'class initialization' }
IceGitHubRejectPullRequestPresenter class >> initialize [

Expand Down Expand Up @@ -58,12 +63,6 @@ IceGitHubRejectPullRequestPresenter >> defaultType [
^ 'merge'
]

{ #category : 'api' }
IceGitHubRejectPullRequestPresenter >> initialExtentForWindow [

^ (500 @ 250) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceGitHubRejectPullRequestPresenter >> initializeDialogWindow: aDialogWindowPresenter [

Expand Down
13 changes: 7 additions & 6 deletions Iceberg-Plugin-GitHub/IceGitHubRemoveBranchesPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ Class {
#tag : 'View'
}

{ #category : 'accessing' }
IceGitHubRemoveBranchesPresenter class >> defaultPreferredExtent [


^ 550 @ 500
]

{ #category : 'class initialization' }
IceGitHubRemoveBranchesPresenter class >> initialize [

Expand Down Expand Up @@ -44,12 +51,6 @@ IceGitHubRemoveBranchesPresenter >> displayBlock: aBlock [
displayBlock := aBlock
]

{ #category : 'initialization' }
IceGitHubRemoveBranchesPresenter >> initialExtentForWindow [

^ 550 @ 500
]

{ #category : 'initialization' }
IceGitHubRemoveBranchesPresenter >> initialize [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-Plugin-GitHub/IceGitHubTipPullRequestBrowser.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ IceGitHubTipPullRequestBrowser class >> buildSelectionCommandGroupWith: presente
"Nothing to add"
]

{ #category : 'accessing' }
IceGitHubTipPullRequestBrowser class >> defaultPreferredExtent [
^ (1050 @ 800)
]

{ #category : 'instance creation' }
IceGitHubTipPullRequestBrowser class >> newApplication: app model: aModel pullRequest: aPullRequest [

Expand Down Expand Up @@ -121,12 +126,6 @@ IceGitHubTipPullRequestBrowser >> diff [
^ diff
]

{ #category : 'initialization' }
IceGitHubTipPullRequestBrowser >> initialExtentForWindow [

^ (1050 @ 800) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceGitHubTipPullRequestBrowser >> initializeCommitsTable [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-Plugin-GitHub/IceTipGitHubPullRequestListBrowser.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ IceTipGitHubPullRequestListBrowser class >> buildSelectionCommandGroupWith: pres

]

{ #category : 'accessing' }
IceTipGitHubPullRequestListBrowser class >> defaultPreferredExtent [
^ (700 @ 700)
]

{ #category : 'instance creation' }
IceTipGitHubPullRequestListBrowser class >> onRepository: aRepository [

Expand Down Expand Up @@ -95,12 +100,6 @@ IceTipGitHubPullRequestListBrowser >> fetchPullRequests [
yourself ]
]

{ #category : 'initialization' }
IceTipGitHubPullRequestListBrowser >> initialExtentForWindow [

^ (700 @ 700) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipGitHubPullRequestListBrowser >> initializePresenters [

Expand Down
14 changes: 6 additions & 8 deletions Iceberg-Plugin-Migration/IceTipFiletreeToTonelDialogPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ Class {
#tag : 'UI'
}

{ #category : 'accessing' }
IceTipFiletreeToTonelDialogPresenter class >> defaultPreferredExtent [

^ 500 @ (self inputTextHeight * 5 + self buttonHeight + 50)
]

{ #category : 'actions' }
IceTipFiletreeToTonelDialogPresenter >> accept [

Expand Down Expand Up @@ -88,14 +94,6 @@ IceTipFiletreeToTonelDialogPresenter >> iconPanel [
^ iconPanel
]

{ #category : 'initialization' }
IceTipFiletreeToTonelDialogPresenter >> initialExtentForWindow [

^ (500
@ (self class inputTextHeight * 5 + self class buttonHeight + 50))
scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipFiletreeToTonelDialogPresenter >> initializePresenters [

Expand Down
12 changes: 5 additions & 7 deletions Iceberg-TipUI/IceTipAddPlaintextCredentialsPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Class {
#tag : 'Credentials'
}

{ #category : 'accessing' }
IceTipAddPlaintextCredentialsPresenter class >> defaultPreferredExtent [
^ (350 @ (self inputTextHeight * 5 + self buttonHeight))
]

{ #category : 'testing' }
IceTipAddPlaintextCredentialsPresenter >> accept [

Expand All @@ -38,13 +43,6 @@ IceTipAddPlaintextCredentialsPresenter >> hostnameFromInput [
^ hostInput text
]

{ #category : 'initialization' }
IceTipAddPlaintextCredentialsPresenter >> initialExtentForWindow [

^ (350 @ (self class inputTextHeight * 5 + self class buttonHeight))
scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAddPlaintextCredentialsPresenter >> initializePresenters [

Expand Down
16 changes: 6 additions & 10 deletions Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ Class {
#tag : 'View-Repository'
}

{ #category : 'accessing' }
IceTipAddRemoteDialogPresenter class >> defaultPreferredExtent [

^ 500 @ (self inputTextHeight * 2 + self buttonHeight + 50) "Yes, a magic number"
]

{ #category : 'actions' }
IceTipAddRemoteDialogPresenter >> accept [

Expand All @@ -43,16 +49,6 @@ IceTipAddRemoteDialogPresenter >> defaultLayout [

]

{ #category : 'initialization' }
IceTipAddRemoteDialogPresenter >> initialExtentForWindow [

^ (500@(
self class inputTextHeight * 2
+ self class buttonHeight
+ 50 "Yes, a magic number"
)) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAddRemoteDialogPresenter >> initializePresenters [

Expand Down
12 changes: 5 additions & 7 deletions Iceberg-TipUI/IceTipAddSSHCredentialsPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Class {
#tag : 'Credentials'
}

{ #category : 'accessing' }
IceTipAddSSHCredentialsPresenter class >> defaultPreferredExtent [
^ (350 @ (self inputTextHeight * 7 + self buttonHeight))
]

{ #category : 'actions' }
IceTipAddSSHCredentialsPresenter >> accept [

Expand All @@ -39,13 +44,6 @@ IceTipAddSSHCredentialsPresenter >> hostnameFromInput [
^ hostInput text
]

{ #category : 'initialization' }
IceTipAddSSHCredentialsPresenter >> initialExtentForWindow [

^ (350 @ (self class inputTextHeight * 7 + self class buttonHeight))
scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAddSSHCredentialsPresenter >> initializePresenters [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-TipUI/IceTipAddTokenCredentialsPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Class {
#tag : 'Credentials'
}

{ #category : 'accessing' }
IceTipAddTokenCredentialsPresenter class >> defaultPreferredExtent [
^ (350 @ (self inputTextHeight * 5 + self buttonHeight))
]

{ #category : 'accessing' }
IceTipAddTokenCredentialsPresenter >> accept [

Expand Down Expand Up @@ -44,12 +49,6 @@ IceTipAddTokenCredentialsPresenter >> hostnameFromInput [
^ hostInput text
]

{ #category : 'initialization' }
IceTipAddTokenCredentialsPresenter >> initialExtentForWindow [

^ (350 @ (self class inputTextHeight * 5 + self class buttonHeight)) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAddTokenCredentialsPresenter >> initializePresenters [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-TipUI/IceTipAskForPlaintextCredentialsPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ Class {
#tag : 'Credentials'
}

{ #category : 'accessing' }
IceTipAskForPlaintextCredentialsPresenter class >> defaultPreferredExtent [
^ (450 @ 180)
]

{ #category : 'actions' }
IceTipAskForPlaintextCredentialsPresenter >> accept [

Expand Down Expand Up @@ -46,12 +51,6 @@ IceTipAskForPlaintextCredentialsPresenter >> defaultLayout [

]

{ #category : 'initialization' }
IceTipAskForPlaintextCredentialsPresenter >> initialExtentForWindow [

^ (450 @ 180) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAskForPlaintextCredentialsPresenter >> titleForWindow [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-TipUI/IceTipAskForPlaintextOtpCredentialsPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ Class {
#tag : 'Credentials'
}

{ #category : 'accessing' }
IceTipAskForPlaintextOtpCredentialsPresenter class >> defaultPreferredExtent [
^ (350 @ 210)
]

{ #category : 'layout' }
IceTipAskForPlaintextOtpCredentialsPresenter >> defaultLayout [

Expand All @@ -28,12 +33,6 @@ IceTipAskForPlaintextOtpCredentialsPresenter >> defaultLayout [
yourself
]

{ #category : 'initialization' }
IceTipAskForPlaintextOtpCredentialsPresenter >> initialExtentForWindow [

^ (350 @ 210) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipAskForPlaintextOtpCredentialsPresenter >> initializePresenters [

Expand Down
11 changes: 5 additions & 6 deletions Iceberg-TipUI/IceTipBrowser.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ IceTipBrowser class >> buildSelectionExtraCommandGroupWith: presenter for: aComm
aCommandGroup register: (IceFiletreeToTonelCommand forSpecContext: presenter)
]

{ #category : 'accessing' }
IceTipBrowser class >> defaultPreferredExtent [
^ (600 @ 400)
]

{ #category : 'commands' }
IceTipBrowser class >> generalCommandGroupName [

Expand Down Expand Up @@ -120,12 +125,6 @@ IceTipBrowser >> iconForWindow [
^ self iconNamed: #komitterSmalltalkhubRemote
]

{ #category : 'initialization' }
IceTipBrowser >> initialExtentForWindow [

^ (600 @ 400) scaledByDisplayScaleFactor
]

{ #category : 'initialization' }
IceTipBrowser >> initialize [

Expand Down
Loading
Loading