Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(tables): split formatting vs evaluation #1686

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

guillep
Copy link
Contributor

@guillep guillep commented Dec 20, 2024

add formatting block to columns.
Evaluation resolves the projection of the object to show.
Formatting returns the string representation to show.

Why is this important

This is important because sorting works on top of the evaluation.
Otherwise, if the sorting works on the string representation, the sort blocks should (re) parse and rebuild the original object to sort.

Otherwise, the (alphabetic) sorting of numerals or other will have the following sorting:

"Invalid alphabetic sorting of numeric values from the string representation"
1KB
10KB
100KB
2KB
20KB
200KB

Instead of the expected:

"Valid sorting of numeric values independently of their formatting"
1KB
2KB
10KB
20KB
100KB
200KB

@jecisc jecisc merged commit b1c430c into pharo-spec:Pharo13 Jan 7, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants