1670 introduce a common st command superclass #1671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ducasse
commented
Nov 26, 2024
Ducasse
commented
- Sorting command into NewTools and
- other default presenters
Make sure default textdition command are not sublass of StToolCommand but SpToolCommand
…rrect prefix. St are for Pharo Spec Tools. Sp are for spec
|
you cannot do an "St" (which would be newtools dependent) superclass in spec. There is a layer violation there. |
|
But after we will move the commands St to NewTools. It loosk in Pharo we put extra luxury to create rules that force us to spend more time on not exciting and interesting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.