Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Options presenter for text search input fields #1607

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Add Options presenter for text search input fields #1607

merged 3 commits into from
Sep 21, 2024

Conversation

hernanmd
Copy link
Member

This PR introduces a new Options widget for text search input fields. The widget includes the following features:

  • Search type selection (radio buttons):
    • Substring search
    • Regular expression search
    • Exact matching
  • Case sensitivity toggle (checkbox)

Details

  • Utilizes radio buttons for mutually exclusive search types
  • Implements a checkbox for case sensitivity option
  • Ensures proper state management and UI updates based on user selections
  • Includes tooltips for clarity on advanced options (e.g., regex search)

Testing

  • Unit tests for each search type and case sensitivity option

Hernán Morales Durand added 3 commits September 20, 2024 18:46
@hernanmd hernanmd mentioned this pull request Sep 20, 2024
Merged
@Ducasse Ducasse merged commit eca5e00 into pharo-spec:Pharo13 Sep 21, 2024
2 checks passed
@hernanmd hernanmd deleted the add_search_input_presenter branch November 19, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernanmd @Ducasse