Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Spec component list example #1488

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Dec 9, 2023

This PR add a presenter example in Pharo 12 to show the basic usage of a component list. The component list holds items which are collected as presenters, each time an item is clicked a detail list is updated.

Add also tests for opening and selection.

@Ducasse
Copy link
Contributor

Ducasse commented Dec 9, 2023

Thanks!
In addition we should probably add a test that checks that all the examples are actually at least opening.

@Ducasse
Copy link
Contributor

Ducasse commented Dec 10, 2023

No idea why the integration is failing.

Downloading the latest 120 Image:
    http://files.pharo.org/get-files/120/pharoImage-x86_64.zip

Error with status code 56:
286 pharo::prepare_image /home/runner/.smalltalkCI/pharo/run.sh
Error: Process completed with exit code 1.

@hernanmd
Copy link
Member Author

I think the error is unrelated to the PR, but the CI is showing "In progress..."

@jecisc jecisc merged commit 5d4ef14 into pharo-spec:Pharo12 Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants