Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new subclass with unified view based on SpDiffPresenter #1452

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

CarolinaMelendez
Copy link
Contributor

SpDiffPresenter displays a split view. So I added a sub-class that displays a unified view called SpDiffUnifiedPresenter

image

@estebanlm
Copy link
Member

but this will not work.
You need to include StUnifiedDiffChangesMorph in the correct place.
(and call it SpUnifiedDiffChangesMorph) :P

@Ducasse
Copy link
Contributor

Ducasse commented Sep 14, 2023

BTW carolina talk to us if you want to do your bachelor with us at Lille. You can talk to seb.

@CarolinaMelendez
Copy link
Contributor Author

Hi @estebanlm thanks for the review. I see I need to learn more. By the correct place of StUnifiedDiffChangesMorph you mean it should be in the same package together with DiffMorph ?

I would like to add that StUnifiedDiffChangesMorph is not a class I created, I just reuse that class because it already has the unified view there. I don't think I have the right to move the package. There is not a another way that make it works or is necessary to move the the location of StUnifiedDiffChangesMorph ?

@jordanmontt
Copy link
Contributor

Hello, what is needed to accept this PR?

@estebanlm
Copy link
Member

estebanlm commented Oct 17, 2023

heh... nothing :)
EDIT: I just saw there is a problem with dependencies.

@Ducasse Ducasse requested a review from estebanlm February 14, 2024 08:10
@estebanlm estebanlm closed this Feb 20, 2024
@estebanlm estebanlm reopened this Feb 20, 2024
@Ducasse Ducasse changed the base branch from Pharo12 to Pharo13 June 13, 2024 07:30
@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

IAfter 10 min I could not find a way to rerun this PR :(
What a dead interface

@Ducasse Ducasse merged commit c2683e3 into pharo-spec:Pharo13 Jun 13, 2024
1 of 2 checks passed
@Ducasse
Copy link
Contributor

Ducasse commented Jun 13, 2024

So we will see if it breaks and in this case we will revert the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants