Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change announcement api #1374

Closed
wants to merge 2 commits into from
Closed

[WIP] Change announcement api #1374

wants to merge 2 commits into from

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Apr 4, 2023

We changed the Announcement API

when: event do: action

by

when: event do: action for: subscriber

See pharo-project/pharo#13270 for more details

PalumboN added 2 commits April 4, 2023 05:47
@PalumboN
Change Announcement API
8652584 
#when:do: -> #when:do:for:
#whenDisplayDo: -> #whenDisplayDo:for:
@PalumboN
Replacing remained methods #when:do: -> #when:do:for:
2d1b2d3
@PalumboN PalumboN mentioned this pull request Apr 4, 2023
Closed
@PalumboN PalumboN changed the title Change announcement api [WIP] Change announcement api Apr 4, 2023
jecisc
jecisc requested changes May 3, 2023
View reviewed changes
src/Spec2-Adapters-Morphic/SpAbstractMorphicAdapter.class.st
@@ -683,10 +684,10 @@ SpAbstractMorphicAdapter >> vSpaceFill [
]

{ #category : #protocol }
SpAbstractMorphicAdapter >> when: anAnnouncement do: aBlock [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do as in the PR of Pharo and keep the old version deprecated

@jordanmontt
Copy link
Contributor

The code seems ok :) there are just some comments to be fixed

@PalumboN
Copy link
Contributor Author

PalumboN commented Oct 19, 2023 •
edited
Loading

I close this PR because:

  • The change in the Pharo repo was merged to pharo-12
  • I wrote a deprecation rule for that, so the code should be already changed in pharo-12 branch in this PR (in this repo)
  • Probably some improvements could be made on this side too, but I prefer to do it in another PR :)

@PalumboN PalumboN closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PalumboN @jordanmontt @jecisc