Adding textChanged notification to SpStringTableColumn #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…along with the current carrige return acceptance. I couldn't find a way to create a unit tes for this as the edits take place in a popup string input morph and there are no easy controls of that from the String colum or the table presenter. However, I did update SpTablePresenter??exampleWriteabltTable to test this. In order to test: 1. Open a Transcript window. 2. execute SpTablePresenter exampleWriteableTable in a Playground. 3. Click your mouse into any row of the left hand editable column and edit a field. Updates should be written to the Transcript.
|
Hello, what is needed to accept this PR? @estebanlm |
|
@jordanmontt first of all this should now be going to Pharo12 branch, not to Pharo11 ;) |
|
It seems that you changed the target branch :) |
|
lol, this thing never went to the trunk :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #12884 on Pharo-project-pharo
Currently an SpStringTableColumn can be set to editable, but the changes are only sent to the table #items when the user does a carriage return.
This change adds a text changes event which will sent updates to the table at each keystroke.
I could not figure out a way to write a test case for this, as the editing occurs in a popup text input over the string column. But I did include a change to SpTablePresenter >> exampleWriteableTable which excercises the change. To run this code: