Merge pull request #1258 from pharo-spec/dev-1.0

small changes
pharo-spec · Mar 18, 2022 · e832d9b · e832d9b
2 parents d6ff725 + 887b91d
commit e832d9b
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 35 deletions.
diff --git a/src/Spec2-Code-Morphic/SpMorphicCodeAdapter.class.st b/src/Spec2-Code-Morphic/SpMorphicCodeAdapter.class.st
@@ -62,10 +62,11 @@ SpMorphicCodeAdapter >> changeLineNumbers: hasLineNumbers to: aMorph [
 { #category : #'private - shout' }
 SpMorphicCodeAdapter >> classOrMetaClass: aClass [
 
-	self 
-		setEditingModeFor: self widget textArea 
-		withBehavior: aClass
-		forScripting: self isForScripting
+	self suspendObservedPropertiesWhile: [ 
+		self 
+			setEditingModeFor: self widget textArea 
+			withBehavior: aClass
+			forScripting: self isForScripting ]
 ]
 
 { #category : #private }
@@ -203,10 +204,11 @@ SpMorphicCodeAdapter >> setEditingModeFor: textArea [
 
 	self hasSyntaxHighlight
 		ifTrue: [ 
-			self 
-				setEditingModeFor: textArea 
-				withBehavior: self behavior 
-				forScripting: self isForScripting ]
+			self suspendObservedPropertiesWhile: [  
+				self 
+					setEditingModeFor: textArea 
+					withBehavior: self behavior 
+					forScripting: self isForScripting ] ]
 		ifFalse: [ 
 			super setEditingModeFor: textArea ]
 ]
@@ -247,6 +249,17 @@ SpMorphicCodeAdapter >> setSyntaxHighlightThemeFor: textArea [
 		refreshStyling
 ]
 
+{ #category : #private }
+SpMorphicCodeAdapter >> suspendObservedPropertiesWhile: aBlock [ 
+	| textHolder textSubscriptions |
+
+	textHolder := self presenter observablePropertyNamed: #text.
+	textSubscriptions := textHolder subscriptions.
+	textHolder subscriptions: #().
+	aBlock ensure: [ 
+		textHolder subscriptions: textSubscriptions ]
+]
+
 { #category : #private }
 SpMorphicCodeAdapter >> textWithStyle [
 	"This method is to be used for testing. 

diff --git a/src/Spec2-Code-Tests/SpCodePresenterTest.class.st b/src/Spec2-Code-Tests/SpCodePresenterTest.class.st
@@ -41,6 +41,16 @@ SpCodePresenterTest >> newEnvironment [
 	^ environment
 ]
 
+{ #category : #tests }
+SpCodePresenterTest >> testChangingEditingModeDoesNotTriggersTextChanged [
+	| changed |
+
+	changed := false.
+	presenter whenTextChangedDo: [ changed := true ].
+	presenter beForBehavior: Object.
+	self deny: changed	
+]
+
 { #category : #tests }
 SpCodePresenterTest >> testContextKeyBindings [
 	| contextKeyBindings |

diff --git a/src/Spec2-Core/SpListPresenter.class.st b/src/Spec2-Core/SpListPresenter.class.st
@@ -143,27 +143,6 @@ SpListPresenter >> iconFor: anItem [
 		cull: self
 ]
 
-{ #category : #api }
-SpListPresenter >> icons [
-	"Return the block used to return an icon that will be displayed in the list"
-	self 
-		deprecated: 'Use #displayIcon' 
-		transformWith: '`@receiver icons' -> '`@receiver displayIcon'.
-
-	^ icon
-]
-
-{ #category : #api }
-SpListPresenter >> icons: aBlock [
-	"Set a block which takes an item as argument and returns the icon to display in the list. 
-	 `aBlock` receives one argument"
-	self 
-		deprecated: 'Use #displayIcon:' 
-		transformWith: '`@receiver icons: `@arg' -> '`@receiver displayIcon: `@arg'.
-
-	icon := aBlock
-]
-
 { #category : #initialization }
 SpListPresenter >> initialize [
 

diff --git a/src/Spec2-Core/SpTPresenterBuilder.trait.st b/src/Spec2-Core/SpTPresenterBuilder.trait.st
@@ -105,6 +105,11 @@ SpTPresenterBuilder >> newGridLayout [
 	^ SpGridLayout new
 ]
 
+{ #category : #'scripting - widgets' }
+SpTPresenterBuilder >> newImage [
+	^ self instantiate: SpImagePresenter
+]
+
 { #category : #'scripting - widgets' }
 SpTPresenterBuilder >> newLabel [
 	^ self instantiate: SpLabelPresenter

diff --git a/src/Spec2-Core/SpTextInputFieldPresenter.class.st b/src/Spec2-Core/SpTextInputFieldPresenter.class.st
@@ -203,6 +203,6 @@ SpTextInputFieldPresenter >> whenSubmitDo: aBlock [
 	 `aBlock` receives one argument (the submited text)"
 
 	self 
-		bindKeyCombination: Character cr asKeyCombination | $s meta 
+		bindKeyCombination: SpAcceptChangesCommand defaultShortcutKey | Character cr asKeyCombination 
 		toAction: aBlock
 ]
diff --git a/src/Spec2-Morphic/SpTPresenterBuilder.extension.st b/src/Spec2-Morphic/SpTPresenterBuilder.extension.st
@@ -1,10 +1,5 @@
 Extension { #name : #SpTPresenterBuilder }
 
-{ #category : #'*Spec2-Morphic' }
-SpTPresenterBuilder >> newImage [
-	^ self instantiate: SpImagePresenter
-]
-
 { #category : #'*Spec2-Morphic' }
 SpTPresenterBuilder >> newLink [
 	^ self instantiate: SpLinkPresenter