return nil instead of self when no action available

pharo-spec · Jun 13, 2024 · 34e1541 · 34e1541
1 parent 3beb538
commit 34e1541
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Spec2-Core/SpAbstractPresenter.class.st b/src/Spec2-Core/SpAbstractPresenter.class.st
@@ -548,7 +548,7 @@ SpAbstractPresenter >> withAdapterDo: aValuable [
 { #category : 'private - utilities' }
 SpAbstractPresenter >> withWindowDo: aValuable [
 
-	self hasWindow ifFalse: [ ^ self ].
+	self hasWindow ifFalse: [ ^ nil ].
 	"Since Presenter has window, root = window"
 	^ aValuable value: self root
 ]
diff --git a/src/Spec2-Core/SpDialogWindowPresenter.class.st b/src/Spec2-Core/SpDialogWindowPresenter.class.st
@@ -270,6 +270,6 @@ SpDialogWindowPresenter >> triggerOkAction [
 	"Trigger defined ok action. 
 	 See `SpDialogWindowPresenter>>#okAction:`"
 
-	okAction ifNil: [ ^ self ].
+	okAction ifNil: [ ^ nil ].
 	^ okAction cull: self
 ]