Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning more tool API #987

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Cleaning more tool API #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NewTools-Keymapping/KMDescriptionPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ KMDescriptionPresenter >> initializePresenters [
actionBar := self newActionBar.
actionBar
addLast: (SpButtonPresenter new
action: [ self application tools browser openOnClass: shortcutTable selectedItem action methodClass selector: shortcutTable selectedItem action selector ];
action: [ (self application toolNamed: #browser) openOnClass: shortcutTable selectedItem action methodClass selector: shortcutTable selectedItem action selector ];
label: 'Browse';
yourself);
addLast: (SpButtonPresenter new
action: [ self application tools inspector openOn: shortcutTable selectedItem inspect ];
action: [ (self application toolNamed: #inspector) openOn: shortcutTable selectedItem inspect ];
label: 'Inspect';
yourself)
]
Expand Down
9 changes: 5 additions & 4 deletions src/NewTools-Spotter/ToolShortcutsCategory.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ ToolShortcutsCategory >> openSpotter [

<shortcut>
^ KMKeymap shortcut: Character cr shift action: [ :target |
| selection |
| selection spot |
selection := target selection.
(self tools spotter insertsSelection and: [ selection isNotNil ])
ifTrue: [ self tools spotter openWithText: selection ]
ifFalse: [ self tools spotter open ] ]
spot := (self tools toolNamed: #spotter).
( spot insertsSelection and: [ selection isNotNil ])
ifTrue: [ spot openWithText: selection ]
ifFalse: [ spot open ] ]
]
Loading