Move keymapping UI to NewTools #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix a dependency test
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Feb 4, 2025
To fix a dependency test. Requires: pharo-spec/NewTools#981
|
Hi we have Tell me if I should integrate it now and we fix it after |
|
Hum... I'll need to check into more detail what is causing this. Let's not merge |
|
We should now be able to merge because I'm fixing those tests here: pharo-project/pharo#17770 This change removes unwanted dependencies and we need to remove them on the Pharo side :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix a dependency test