Fixes #17443 on pharo #912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion because it was impossible to scroll if the prtocol name changes everytime we select a protocol in the list
|
Hi alexis S |
|
I know what is the goal and I'm planning to review it. I just got busy today |
|
Ok thanks cyril! |
|
Hum... I tried it and this reduces the usability because when we validate it takes when is in the input field and not in the list. I'll need to think better about how to improve the UX of this presenter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed suggestionlist selection in initialization because it was impossible to scroll if the prtocol name changes everytime we select a protocol in the list