Fixing missing defaultLayout

title definition
pharo-spec · Jan 28, 2025 · 73cf4d6 · 73cf4d6
1 parent f9cc969
commit 73cf4d6
Show file tree

Hide file tree

Showing 12 changed files with 72 additions and 63 deletions.
diff --git a/src/NewTools-CodeCritiques/StSingleCritiqueResultListPresenter.class.st b/src/NewTools-CodeCritiques/StSingleCritiqueResultListPresenter.class.st
@@ -71,12 +71,6 @@ StSingleCritiqueResultListPresenter class >> open [
 	^ self new open
 ]
 
-{ #category : 'specs' }
-StSingleCritiqueResultListPresenter class >> title [
-
-	^ 'Critique Browser'
-]
-
 { #category : 'icons' }
 StSingleCritiqueResultListPresenter class >> wrenchOrangeIcon [
 
@@ -207,6 +201,16 @@ StSingleCritiqueResultListPresenter >> critiquesOf: aRule [
 			 a printString < b printString ])
 ]
 
+{ #category : 'menu' }
+StSingleCritiqueResultListPresenter >> defaultLayout [
+
+	^ SpBoxLayout newTopToBottom
+		  add: #critiquesModel;
+		  add: #toolbarModel height: 25;
+		  add: #sourceCodeModel;
+		  yourself
+]
+
 { #category : 'private' }
 StSingleCritiqueResultListPresenter >> diffSeparator [
 
@@ -473,3 +477,9 @@ StSingleCritiqueResultListPresenter >> whenSelectedItemChangesOnListModel [
 					ifTrue: [ self setTextModelForTransformationRule: critique ]
 					ifFalse: [ self setTextModelForClassOrMethod: critique ] ] ] ]
 ]
+
+{ #category : 'accessing' }
+StSingleCritiqueResultListPresenter >> windowTitle [
+
+	^ 'Critique Browser'
+]
diff --git a/src/NewTools-Debugger/StDebugger.class.st b/src/NewTools-Debugger/StDebugger.class.st
@@ -1548,15 +1548,15 @@ StDebugger >> warning: aString for: aPresenter [
 		popup
 ]
 
-{ #category : 'initialization' }
-StDebugger >> windoTitle [
-
-	^  self debuggerActionModel statusStringForContext
-]
-
 { #category : 'initialization' }
 StDebugger >> windowIcon [
 
 	^ self iconNamed: #smallDebug
 
 ]
+
+{ #category : 'initialization' }
+StDebugger >> windowTitle [
+
+	^  self debuggerActionModel statusStringForContext
+]
diff --git a/src/NewTools-Debugger/StDebuggerInspector.class.st b/src/NewTools-Debugger/StDebuggerInspector.class.st
@@ -42,11 +42,6 @@ StDebuggerInspector class >> openOn: anObject [
 	^ (self on: (StInspectorModel on: anObject)) open
 ]
 
-{ #category : 'specs' }
-StDebuggerInspector class >> title [
-	 ^'Debugger Inspection'
-]
-
 { #category : 'specs' }
 StDebuggerInspector class >> toggleMaximizeAssertionSpec [
 	self maximizeAssertionSpec: self maximizeAssertionSpec not
@@ -309,3 +304,9 @@ StDebuggerInspector >> updateWith: inspectedObject [
 	self updateEvaluationPaneReceiver.
 	self restoreRawInspectionSelectionForContext: newContext
 ]
+
+{ #category : 'accessing' }
+StDebuggerInspector >> windowTitle [
+
+	 ^'Debugger Inspection'
+]
diff --git a/src/NewTools-FileBrowser/StFileSystemPresenter.class.st b/src/NewTools-FileBrowser/StFileSystemPresenter.class.st
@@ -198,7 +198,7 @@ StFileSystemPresenter >> openFolder: aFileReference [
 { #category : 'accessing' }
 StFileSystemPresenter >> title: aString [
 
-	title := aString.
+	title := aString
 ]
 
 { #category : 'accessing' }

diff --git a/src/NewTools-Inspector/StInspectorPresenter.class.st b/src/NewTools-Inspector/StInspectorPresenter.class.st
@@ -281,7 +281,7 @@ StInspectorPresenter >> updateTitle [
 
 	self isRoot ifFalse: [ ^ self ].
 	self withWindowDo: [ :window | 
-		window title: self title ].
+		window title: self windowTitle ].
 ]
 
 { #category : 'initialization' }
@@ -292,16 +292,18 @@ StInspectorPresenter >> windowIcon [
 
 { #category : 'initialization' }
 StInspectorPresenter >> windowTitle [
-
-	^ self model windowTitle
+	
+	^ self model ifNotNil: [ :m | m windowTitle ] ifNil: [ 'Inspector']
 ]
 
 { #category : 'accessing' }
 StInspectorPresenter >> withHeaderBar [
-	 ^withHeaderBar ifNil: [ withHeaderBar := true ]
+
+	 ^ withHeaderBar ifNil: [ withHeaderBar := true ]
 ]
 
 { #category : 'accessing' }
 StInspectorPresenter >> withHeaderBar: bool [
+
 	withHeaderBar := bool
 ]
diff --git a/src/NewTools-MethodBrowsers/StMessageBrowser.class.st b/src/NewTools-MethodBrowsers/StMessageBrowser.class.st
@@ -122,12 +122,6 @@ StMessageBrowser class >> taskbarIconName [
 	^#references
 ]
 
-{ #category : 'specs' }
-StMessageBrowser class >> title [
-
-	^ 'Message Browser'
-]
-
 { #category : 'private' }
 StMessageBrowser class >> usingLayout [
 
@@ -632,5 +626,5 @@ StMessageBrowser >> windowIsClosing [
 { #category : 'private' }
 StMessageBrowser >> windowTitle [
 
-	^ (title ifNil: [ self class title ]), ' [' , messageList numberOfElements printString , ']'
+	^ (title ifNil: [ 'Message Browser' ]), ' [' , messageList numberOfElements printString , ']'
 ]
diff --git a/src/NewTools-MethodBrowsers/StMethodToolbarPresenter.class.st b/src/NewTools-MethodBrowsers/StMethodToolbarPresenter.class.st
@@ -37,12 +37,6 @@ StMethodToolbarPresenter class >> example [
 	^ example
 ]
 
-{ #category : 'specs' }
-StMethodToolbarPresenter class >> title [
-
-	^ 'Toolbar'
-]
-
 { #category : 'accessing' }
 StMethodToolbarPresenter >> addItemLabeled: aString do: aBlock [
 	| item |
@@ -183,3 +177,9 @@ StMethodToolbarPresenter >> setModelBeforeInitialization: aMethod [
 
 	self method: aMethod
 ]
+
+{ #category : 'accessing' }
+StMethodToolbarPresenter >> windowTitle [
+
+	^ 'Toolbar'
+]
diff --git a/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st b/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st
@@ -60,6 +60,12 @@ StPlaygroundBindingsPresenter >> defaultLayout [
 		yourself
 ]
 
+{ #category : 'initialization' }
+StPlaygroundBindingsPresenter >> defaultWindowTitle [
+
+	^ 'Bindings'
+]
+
 { #category : 'testing' }
 StPlaygroundBindingsPresenter >> hasSelectedBinding [
 
@@ -229,14 +235,6 @@ StPlaygroundBindingsPresenter >> sortedBindingAssociations [
 	^ self bindings associations sort: [ :a | self isLocalBinding: a ] ascending
 ]
 
-{ #category : 'initialization' }
-StPlaygroundBindingsPresenter >> title [
-
-	parent withWindowDo: [ :w | 
-		^ 'Bindings for {1}' format: { w title } ].
-	^ self windowTitle
-]
-
 { #category : 'actions' }
 StPlaygroundBindingsPresenter >> toggleSelectedBindingScope [
 
@@ -285,8 +283,10 @@ StPlaygroundBindingsPresenter >> updatePresenterWithSelection: aBlock [
 	newBindings ifNotEmpty: aBlock
 ]
 
-{ #category : 'accessing' }
+{ #category : 'initialization' }
 StPlaygroundBindingsPresenter >> windowTitle [
 
-	^ 'Bindings'
+	parent withWindowDo: [ :w | 
+		^ 'Bindings for {1}' format: { w windowTitle } ].
+	^ self defaultWindowTitle
 ]
diff --git a/src/NewTools-Scopes-Editor/ScopeNodesPresenter.class.st b/src/NewTools-Scopes-Editor/ScopeNodesPresenter.class.st
@@ -51,11 +51,6 @@ ScopeNodesPresenter class >> reset [
 	LastSearch := nil
 ]
 
-{ #category : 'specs' }
-ScopeNodesPresenter class >> title [
-	^ 'Scope creator'
-]
-
 { #category : 'private - actions' }
 ScopeNodesPresenter >> activateItem: scopeNode [
 
@@ -470,3 +465,9 @@ ScopeNodesPresenter >> validate [
 	checkedScopeNodes ifEmpty: [ ^ false ].
 	^ true
 ]
+
+{ #category : 'accessing' }
+ScopeNodesPresenter >> windowTitle [
+
+	^ 'Scope creator'
+]
diff --git a/src/NewTools-Scopes-Editor/ScopesPresenter.class.st b/src/NewTools-Scopes-Editor/ScopesPresenter.class.st
@@ -70,11 +70,6 @@ ScopesPresenter class >> refreshAllInstances [
 	self allInstances do: [ :each | each refresh ]
 ]
 
-{ #category : 'specs' }
-ScopesPresenter class >> title [
-	^ 'Scopes Editor'
-]
-
 { #category : 'api' }
 ScopesPresenter >> addScopeToTree: aRBEnvironment [
 
@@ -536,3 +531,9 @@ ScopesPresenter >> updateScopesTree [
 
 	scopesTree updateRootsKeepingSelection: self scopeNodes
 ]
+
+{ #category : 'accessing' }
+ScopesPresenter >> windowTitle [
+
+	^ 'Scope Editor'
+]
diff --git a/src/NewTools-Sindarin-Tools/StSindarinDebuggerPresenter.class.st b/src/NewTools-Sindarin-Tools/StSindarinDebuggerPresenter.class.st
@@ -28,11 +28,6 @@ StSindarinDebuggerPresenter class >> defaultLayout [
 		yourself
 ]
 
-{ #category : 'specs' }
-StSindarinDebuggerPresenter class >> title [
-	^'Sindarin Debugger'
-]
-
 { #category : 'initialization' }
 StSindarinDebuggerPresenter >> buildToolbar [
 	| group |
@@ -93,3 +88,8 @@ StSindarinDebuggerPresenter >> stepOver [
 	self model stepOver.
 	self refresh
 ]
+
+{ #category : 'stepping' }
+StSindarinDebuggerPresenter >> windowTitle [
+	^'Sindarin Debugger'
+]
diff --git a/src/NewTools-Spotter/StSpotter.class.st b/src/NewTools-Spotter/StSpotter.class.st
@@ -79,10 +79,10 @@ StSpotter class >> createTips [
 
 { #category : 'accessing' }
 StSpotter class >> defaultPreferredExtent [
-
+	self halt. 
 	^ self isShowingPreview 
-		ifTrue: [ (750@650) ]
-		ifFalse: [ (500@650) ]
+		ifTrue: [ (750@850) ]
+		ifFalse: [ (500@850) ]
 ]
 
 { #category : 'accessing' }