Fix senders broken in Calypso editors #17011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
You should maybe open an issue about the incorrect rewrite in this case:
I’m also wondering why the severity of that rule is ‘warning’ and not just ‘information’. The rule’s rationale says that the rewrite might better represent the true meaning, implying that’s not necessarily the case, so it would seem better that the rule just informs me that I could rewrite the method, not warn me that I should. |
|
Hi Kris I agree with you. Can you open a separate issue? We should at least reword the rule |
|
I opened an issue about it: issue #17013. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CTRL/CMD+N broken in Calypso editors after auto-rewrite refactoring suggestion, as reported by @Rinzwind in #17004
Failing tests are related to Spec scroll index and now fixed in pharo-spec/Spec#1587