more tests

src/Toplo-Tests/ToOverlayWindowManagerTest.class.st

@@ -0,0 +1,58 @@
+"
+A ToOverlayWindowManagerTest is a test class for testing the behavior of ToOverlayWindowManager
+"
+Class {
+	#name : 'ToOverlayWindowManagerTest',
+	#superclass : 'ToParameterizedHostTest',
+	#instVars : [
+		'space'
+	],
+	#category : 'Toplo-Tests-Core-Window',
+	#package : 'Toplo-Tests',
+	#tag : 'Core-Window'
+}
+
+{ #category : 'running' }
+ToOverlayWindowManagerTest >> setUp [ 
+
+	super setUp.
+	space := self newTestingSpace.
+
+]
+
+{ #category : 'tests' }
+ToOverlayWindowManagerTest >> testDefaultSizeHook [
+
+	| e windowManager win |
+	e := ToElement new.
+	space root addChild: e.
+	e position: 10 asPoint.
+	e size: 10 asPoint.
+	windowManager := ToOverlayWindowManager new.
+	windowManager element: e.
+	self assert: (windowManager defaultSizeHook isKindOf: BlockClosure).
+	win := windowManager newWindowEvent: nil.
+	win popup.
+	self waitTestingSpaces.
+	self assert: win bounds inSpace extent equals: e bounds inSpace extent
+]
+
+{ #category : 'tests' }
+ToOverlayWindowManagerTest >> testElementEventHandlerClass [
+
+	| win e  windowManager |
+	e := ToElement new.
+	space root addChild: e.
+	self waitTestingSpaces.
+
+	windowManager := ToOverlayWindowManager new builder: [ :anchWin :element |  ].
+	windowManager element: e.
+	win := windowManager newWindowEvent: nil.
+	win popup.
+	self assert: win element equals: e.
+	self assert: (e eventDispatcher hasEventHandlerSuchThat: [ :eh |
+			 eh isKindOf: ToOverlayedEventHandler ]).
+	win close.
+	self assert: (e eventDispatcher hasEventHandlerSuchThat: [ :eh |
+			 eh isKindOf: ToOverlayedEventHandler ])
+]

src/Toplo-Widget-Album/ToLabelEditorWindowManager.class.st

@@ -7,7 +7,7 @@ Class {
 }
 
 { #category : 'initialization' }
-ToLabelEditorWindowManager >> defaulPositionHook [
+ToLabelEditorWindowManager >> defaultPositionHook [
 
 	^ [ :event :theLabel |
 				theLabel innerElement bounds inSpace bounds topLeft

src/Toplo-Widget-Menu/ToContextMenuWindowManager.class.st

@@ -7,7 +7,7 @@ Class {
 }
 
 { #category : 'initialization' }
-ToContextMenuWindowManager >> defaulPositionHook [
+ToContextMenuWindowManager >> defaultPositionHook [
 
 	^ [ :event :theContextMenu | event position ]
 ]

src/Toplo-Widget-Menu/ToMenuWindowManager.class.st

@@ -7,7 +7,7 @@ Class {
 }
 
 { #category : 'initialization' }
-ToMenuWindowManager >> defaulPositionHook [ 
+ToMenuWindowManager >> defaultPositionHook [ 
 
 	^ [ :event :theMenu | theMenu isSubmenu
 		  ifTrue: [ theMenu bounds inSpace bounds topRight ]

src/Toplo/ToAnchoredWindowManager.class.st

@@ -62,13 +62,21 @@ ToAnchoredWindowManager >> currentWindow: aWindowElement [
 ]
 
 { #category : 'initialization' }
-ToAnchoredWindowManager >> defaulPositionHook [
+ToAnchoredWindowManager >> defaultBuilder [
+
+	^ [ :theWindow :theElement | ]
+
+
+]
+
+{ #category : 'initialization' }
+ToAnchoredWindowManager >> defaultPositionHook [
 
 	^ [ :event :theElement| theElement bounds inSpace bounds topLeft ]
 ]
 
 { #category : 'initialization' }
-ToAnchoredWindowManager >> defaulSizeHook [
+ToAnchoredWindowManager >> defaultSizeHook [
 
 	^ nil
 ]
@@ -90,6 +98,12 @@ ToAnchoredWindowManager >> element: anElement [
 		element addEventHandler: self newElementEventHandler ]
 ]
 
+{ #category : 'accessing' }
+ToAnchoredWindowManager >> elementEventHandler [
+
+	^ elementEventHandler
+]
+
 { #category : 'accessing' }
 ToAnchoredWindowManager >> elementEventHandlerClass [
 
@@ -106,8 +120,9 @@ ToAnchoredWindowManager >> hasWindow [
 ToAnchoredWindowManager >> initialize [ 
 
 	super initialize.
-	self positionHook: self defaulPositionHook.
-	self sizeHook: self defaulSizeHook.
+	self positionHook: self defaultPositionHook.
+	self sizeHook: self defaultSizeHook.
+	self builder: self defaultBuilder.
 
 
 ]
@@ -122,28 +137,34 @@ ToAnchoredWindowManager >> newElementEventHandler [
 
 { #category : 'window handling' }
 ToAnchoredWindowManager >> newWindowEvent: anEvent [
+
 	| request |
 	self currentWindow ifNotNil: [
-		Error signal: 'Asking for a associate window building twice' ].
+		^ Error signal: 'Asking for a window building twice' ].
+	self element ifNil: [ ^ Error signal: 'An element is required for building a window' ].
+	self builder ifNil: [ ^ Error signal: 'A window builder is required for building a window' ].
 	request := self windowRequestClass new
-			 sourceEvent: anEvent;
-			 yourself.
+		           sourceEvent: anEvent;
+		           yourself.
 	self element dispatchEvent: request.
-	self currentWindow: (self newWindowInstanceAfterRequest: request).
+	self currentWindow: (self windowClass new
+			 manager: self;
+			 yourself).
+	builder value: self currentWindow value: request.
 	windowClosedHandler := BlEventHandler
 		                       on: ToWindowClosedEvent
-		                       do: [ self windowClosed ].
+		                       do: [ self onWindowClosed ].
 	self currentWindow addEventHandler: windowClosedHandler.
 	^ self currentWindow
 ]
 
 { #category : 'window handling' }
-ToAnchoredWindowManager >> newWindowInstanceAfterRequest: aRequest [
+ToAnchoredWindowManager >> onWindowClosed [
 
-	| w |
-	w := self windowClass new manager: self; yourself.
-	builder value: w value: aRequest.
-	^ w
+	self currentWindow removeEventHandler: windowClosedHandler.
+	windowClosedHandler := nil.
+	currentWindow manager: nil.
+	currentWindow := nil
 ]
 
 { #category : 'accessing' }
@@ -182,15 +203,6 @@ ToAnchoredWindowManager >> windowClass [
 	^ ToAnchoredWindow 
 ]
 
-{ #category : 'window handling' }
-ToAnchoredWindowManager >> windowClosed [
-
-	self currentWindow removeEventHandler: windowClosedHandler.
-	windowClosedHandler := nil.
-	currentWindow manager: nil.
-	currentWindow := nil
-]
-
 { #category : 'accessing' }
 ToAnchoredWindowManager >> windowRequestClass [
 

src/Toplo/ToOverlayWindowManager.class.st

@@ -7,7 +7,7 @@ Class {
 }
 
 { #category : 'initialization' }
-ToOverlayWindowManager >> defaulSizeHook [
+ToOverlayWindowManager >> defaultSizeHook [
 
 	^ [ :event :theElement | theElement size ]
 ]

src/Toplo/ToPopupWindowManager.class.st

@@ -23,7 +23,7 @@ ToPopupWindowManager >> autoCloseOnMouseUpDelay: aDelay [
 ]
 
 { #category : 'initialization' }
-ToPopupWindowManager >> defaulPositionHook [
+ToPopupWindowManager >> defaultPositionHook [
 
 	^ [ :event :theElement | theElement bounds inSpace bounds bottomLeft ]
 ]

src/Toplo/ToTooltipWindowManager.class.st

@@ -9,20 +9,20 @@ Class {
 	#tag : 'Core-Tooltip'
 }
 
+{ #category : 'accessing' }
+ToTooltipWindowManager >> defaultPopupDelay [
+
+	^ 700 milliSeconds
+]
+
 { #category : 'initialization' }
-ToTooltipWindowManager >> defaulPositionHook [
+ToTooltipWindowManager >> defaultPositionHook [
 
 	^ [ :event :theElement| 
 	  event position x
 	  @ (theElement localPointToGlobal: 0 @ theElement height) y + self vgap ]
 ]
 
-{ #category : 'accessing' }
-ToTooltipWindowManager >> defaultPopupDelay [
-
-	^ 700 milliSeconds
-]
-
 { #category : 'accessing' }
 ToTooltipWindowManager >> elementEventHandlerClass [