fix construction of DSP ui

pharo-graphics · Jan 23, 2025 · b70426b · b70426b
1 parent 4b23242
commit b70426b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/CoypuIDE/BlElement.extension.st b/CoypuIDE/BlElement.extension.st
@@ -39,8 +39,11 @@ BlElement >> fromDictionary: aDictionary forDsp: aDsp [
 	widgetDictionary := Dictionary new.
 	widgetDictionary
 		add: #hslider -> #ICDarkKnob3;
+		add: #vslider -> #ICDarkKnob3;
 		add: #button -> #ICLabelButton;
-		add: #hbargraph -> #ICValueDisplay.  
+		add: #hbargraph -> #ICValueDisplay; 
+	   add: #nentry -> #ICDarkKnob3; 
+		add: #checkbox -> #ICLabelButton.
 
 	^ (self class environment at:
 		   (widgetDictionary at: (aDictionary at: #type)))

diff --git a/CoypuIDE/DSP.extension.st b/CoypuIDE/DSP.extension.st
@@ -52,8 +52,12 @@ DSP >> displayUI [
 		do: [ :evt | space extent: evt target extent ].
 
 	space root addChild: container.
+
+	space     addEventHandlerOn: BlSpaceClosedEvent
+    do: [ Transcript show: 'Space closed' ].
 	space show.
-	space addEventFilterOn: [ BlSpaceClosedEvent ] do: [ ICValueDisplay isUpdating: false ].
+
+
 	^ space
 ]
 

diff --git a/CoypuIDE/ICKnob.class.st b/CoypuIDE/ICKnob.class.st
@@ -78,13 +78,13 @@ ICKnob class >> fromDictionary: aDictionary [
 
 { #category : 'instance creation' }
 ICKnob class >> fromDictionary: aDictionary forDsp: aDsp [
-
+( aDictionary at: #label ) traceCr.
 	^ (self
-		   label: (aDictionary at: #label)
+		   label: (aDictionary at: #shortname)
 		   minValue: (aDictionary at: #min)
 		   maxValue: (aDictionary at: #max)
 		   callBack: [ :i |
-		   aDsp setValue: i parameter: (aDictionary at: #label) ])
+		   aDsp setValue: i parameter: (aDictionary at: #shortname) ])
 		  setValue: (aDictionary at: #init); stepValue: (aDictionary at: #step)
 ]
 

diff --git a/CoypuIDE/ICLabelButton.class.st b/CoypuIDE/ICLabelButton.class.st
@@ -18,13 +18,13 @@ Class {
 ICLabelButton class >> fromDictionary: aDictionary forDsp: aDsp [
 
 	| paramLabel btn paramLabelAndType |
-	paramLabel := aDictionary at: #label.
+	paramLabel := (aDictionary at: #address) afterLastSlash .
 	"we split the actual label from its type"
 	paramLabelAndType := paramLabel splitOn: $~.
 	btn := self label: (paramLabelAndType at: 1).
 	btn callback: [ :x | aDsp setValue: x parameter: paramLabel ].
 	"if the button is a checkbox"
-	
+
 	paramLabelAndType size > 1 ifTrue: [ btn isToggleable: true ].
 
 	^ btn