cleaning fractal circle

pharo-graphics · Jun 12, 2024 · ae640f5 · ae640f5
1 parent 7846fcf
commit ae640f5
Show file tree

Hide file tree

Showing 15 changed files with 26 additions and 45 deletions.
diff --git a/Mooflod.package/MfFractalCircleElement.class/class/exampleSimpleFractalCircle.st b/Mooflod.package/MfFractalCircleElement.class/class/exampleSimpleFractalCircle.st
@@ -0,0 +1,14 @@
+example
+exampleSimpleFractalCircle
+
+	<script>
+	| c space | 
+	c := MfFractalCircleElement new.
+	c setValue: 100.
+	space := BlSpace new.
+	space root layout: BlFlowLayout horizontal.
+	c transformDo: [ :c | c translateBy: 200 @ 150 ].
+	space toTheme: MfMooflodTheme new.
+	space root addChild: c.
+	space show.
+	^ c
diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/circleExtent.st b/Mooflod.package/MfFractalCircleElement.class/instance/circleExtent.st
@@ -1,4 +1,4 @@
-as yet unclassified
+initialization
 circleExtent
 
 	^ 390 @ 390
diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/createCircle.y..st b/Mooflod.package/MfFractalCircleElement.class/instance/createCircle.y..st
@@ -1,4 +1,4 @@
-as yet unclassified
+internal
 createCircle: x y: anY
 
 	| c |

diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/createCircle.y.color..st b/Mooflod.package/MfFractalCircleElement.class/instance/createCircle.y.color..st
@@ -1,4 +1,4 @@
-as yet unclassified
+internal
 createCircle: x y: anY color: aColor
 
 	| c color |

diff --git a/...ircleElement.class/instance/nbOfChilds.st → ...Element.class/instance/numberOfCircles.st b/...ircleElement.class/instance/nbOfChilds.st → ...Element.class/instance/numberOfCircles.st
@@ -1,4 +1,4 @@
 accessing
-nbOfChilds
+numberOfCircles
 
 ^nbOfChilds 
diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/openFractalCircle..st b/Mooflod.package/MfFractalCircleElement.class/instance/openFractalCircle..st
diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/setValue..st b/Mooflod.package/MfFractalCircleElement.class/instance/setValue..st
@@ -1,7 +1,8 @@
-as yet unclassified
+public api
 setValue: aValue
 
-	(aValue between: 0 and: 100) ifTrue: [ self value: aValue ]
-	ifFalse: [ self value: 100 ].
+	(aValue between: 0 and: 100)
+		ifTrue: [ value := aValue ]
+		ifFalse: [  value := 100 ].
 	nbOfChilds := value / 4.
 	self updateCircles
diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/updateCircles.st b/Mooflod.package/MfFractalCircleElement.class/instance/updateCircles.st
@@ -1,4 +1,4 @@
-as yet unclassified
+internal
 updateCircles
 
 	| c |

diff --git a/Mooflod.package/MfFractalCircleElement.class/instance/value..st b/Mooflod.package/MfFractalCircleElement.class/instance/value..st
diff --git a/Mooflod.package/MfFractalCircleElementTest.class/instance/testIfCirclesAreAddedCorrectly.st b/Mooflod.package/MfFractalCircleElementTest.class/instance/testIfCirclesAreAddedCorrectly.st
@@ -5,4 +5,4 @@ testIfCirclesAreAddedCorrectly
 	circle := MfFractalCircleElement new.
 	circle setValue: 80.
 	"Increment the circles in the widget each 4% incrementation"
-	self assert: circle nbOfChilds equals: 20.
+	self assert: circle numberOfCircles equals: 20.
diff --git a/...lod.package/MfFractalCircleElementTest.class/instance/testNothingAddedIfValueIsTooHigh.st b/...lod.package/MfFractalCircleElementTest.class/instance/testNothingAddedIfValueIsTooHigh.st
@@ -6,4 +6,4 @@ testNothingAddedIfValueIsTooHigh
 	circle setValue: 108.
 	"The fractal circle works with percentage, so value is set to max if too high"
 	self assert: circle value equals: 100.
-	self assert: circle nbOfChilds equals: 25.
+	self assert: circle numberOfCircles equals: 25.
diff --git a/Mooflod.package/MfFractalCircleExamples.class/README.md b/Mooflod.package/MfFractalCircleExamples.class/README.md
diff --git a/Mooflod.package/MfFractalCircleExamples.class/class/exampleSimpleFractalCircle.st b/Mooflod.package/MfFractalCircleExamples.class/class/exampleSimpleFractalCircle.st
diff --git a/Mooflod.package/MfFractalCircleExamples.class/properties.json b/Mooflod.package/MfFractalCircleExamples.class/properties.json
diff --git a/Mooflod.package/MfPatternElementSkin.class/properties.json b/Mooflod.package/MfPatternElementSkin.class/properties.json
@@ -1,6 +1,6 @@
 {
 	"commentStamp" : "",
-	"super" : "ToRawSkin",
+	"super" : "MfBasicMooflodSkin",
 	"category" : "Mooflod-PatternWidget",
 	"classinstvars" : [ ],
 	"pools" : [ ],