Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional auto-approve config on no approver #24

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

edwinkys
Copy link
Contributor

Description

Fixes #22

This PR allows users to optionally configure to auto approve all approver request received by the system when in case there is no approver available. This configuration is great for small team but not recommended in production.

How Has This Been Tested?

  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my changes are working as expected.

I have tested my work by:

  1. Running the server with auto approval configuration active.
  2. Emulate a get approval method
  3. Without any approver connected the auto approval should approve the request.

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

@edwinkys edwinkys linked an issue Nov 22, 2024 that may be closed by this pull request
@edwinkys edwinkys self-assigned this Nov 22, 2024
@edwinkys edwinkys merged commit 2f9bace into main Nov 22, 2024
1 check passed
@edwinkys edwinkys deleted the 22-add-default-verdict-on-no-approver branch November 22, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] add default verdict when no approver is available
1 participant