Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Reading' page with Storygraph link #398

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Replace 'Reading' page with Storygraph link #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions content/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ title = "Philipp Hansch - Ruby, Rust and more"
<td>
<a href="http://github.com/phansch">GitHub</a>
</td>
<td>
<a href="https://app.thestorygraph.com/profile/philh">What I'm reading</a>
</td>
</tr>
</table>
</div>
Expand Down
101 changes: 0 additions & 101 deletions content/books.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion content/posts/2014-02-03-what-i-dont-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ aliases = ["2014/02/03/what-i-dont-know/"]
excerpt = "A list of things I don't know."
+++

I have been reading [Apprenticeship Patterns](https://www.amazon.com/Apprenticeship-Patterns-Guidance-Aspiring-Craftsman/dp/0596518382) by Dave Hoover and I found a lot of the patterns really helpful. The first thing I put into practice, was to read books and maintain a [reading list](@/reading/index.md).
I have been reading [Apprenticeship Patterns](https://www.amazon.com/Apprenticeship-Patterns-Guidance-Aspiring-Craftsman/dp/0596518382) by Dave Hoover and I found a lot of the patterns really helpful. The first thing I put into practice, was to read books and maintain a [reading list](https://app.thestorygraph.com/profile/philh).

However, this post is not about that. It's about a different pattern: **Expose Your Ignorance**

Expand Down
10 changes: 0 additions & 10 deletions content/reading/index.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion sass/assets/default.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ section.main {

td {
text-align: center;
width: 50%;
width: 33%;
}
}
}
Expand Down
1 change: 0 additions & 1 deletion templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
{% if current_path is defined %}
<a title="About"{% if current_path == "/" %} class="active"{% endif%} href="/" rel="author">About</a> ╵
<a title="Blog"{% if current_path == "/writing/" or "posts" in current_path %} class="active"{% endif%} href="/writing">Blog</a> ╵
<a title="Reading List"{% if current_path == "/reading/" %} class ="active"{% endif %} href="/reading">Reading</a> ╵
<a title="100+ Rust PRs"{% if current_path == "/onehundred/rust/" %} class="active"{% endif%} href="/onehundred/rust">100+ Rust PRs</a> ╵
<a title="Sponsor me"{% if current_path == "/thanks/" %} class="active"{% endif%} href="/thanks">Sponsor me</a>
{% else %}
Expand Down
30 changes: 0 additions & 30 deletions templates/reading.html
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/features/top_navigation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ def test_about_link
assert page.has_content? 'Resumè / CV'
end

def test_reading_link
visit '/'
click_link 'Reading'
assert page.has_content? 'reading list'
end

def test_blog_link
visit '/'
click_link 'Blog'
Expand Down
Loading