Fixup longpass auth tests #1269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-strings are `NULL` terminated and so `MAX_PASSWORD_LENGTH` = `MAX_PASSWORD - 1`. Additionally, the regex matcher for pulling out `MAX_PASSWORD` was wrong and only got "2" when it should have been "2048".
cosgroveb
commented
Feb 10, 2025
| assert match is not None | ||
| max_password_length = int(match.group(1)) | ||
| assert max_password_length >= 996 |
There was a problem hiding this comment.
not sure about this bit but an assertion that it's > 2 is needed 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C-strings are
NULLterminated and soMAX_PASSWORD_LENGTH=MAX_PASSWORD - 1.Additionally, the regex matcher for pulling out
MAX_PASSWORDwas wrongand only got "2" when it should have been "2048".
This closes #1268