Fix unnecessary node extensions diff in Terraform plan (#39)

* fix: prevent node extensions diff when unmanaged * fix: prevent unnecessary node extensions diff in terraform plan * fixed auto_manage mutation issue * added back database resource sensitive tag
pgEdge · Nov 12, 2024 · e799ab2 · e799ab2
1 parent 8e824d4
commit e799ab2
Show file tree

Hide file tree

Showing 6 changed files with 263 additions and 215 deletions.
diff --git a/client/client.go b/client/client.go
@@ -328,7 +328,7 @@ func (c *Client) UpdateDatabase(ctx context.Context, id strfmt.UUID, body *model
 		return nil, err
 	}
 
-	return c.GetDatabase(ctx, *resp.Payload.ID)
+	return c.GetDatabase(ctx, id)
 }
 
 func (c *Client) DeleteDatabase(ctx context.Context, id strfmt.UUID) error {

diff --git a/client/models/extensions.go b/client/models/extensions.go
diff --git a/client/swagger/databases.yaml b/client/swagger/databases.yaml
@@ -240,6 +240,8 @@ definitions:
         $ref: "#/definitions/Backups"
   Extensions:
     type: object
+    required:
+      - auto_manage
     properties:
       auto_manage:
         type: boolean

diff --git a/client/swagger/swagger.yaml b/client/swagger/swagger.yaml
@@ -741,6 +741,8 @@ definitions:
         items:
           type: string
         type: array
+    required:
+    - auto_manage
     type: object
   GoogleCredentials:
     properties:

diff --git a/internals/provider/database/data_source.go b/internals/provider/database/data_source.go
@@ -568,7 +568,7 @@ func (d *databasesDataSource) mapExtensionsToModel(extensions *models.Extensions
             "requested":   types.ListType{ElemType: types.StringType},
         },
         map[string]attr.Value{
-            "auto_manage": types.BoolValue(extensions.AutoManage),
+            "auto_manage": types.BoolPointerValue(extensions.AutoManage),
             "available":   d.convertToListValue(extensions.Available),
             "requested":   d.convertToListValue(extensions.Requested),
         },