Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output from rebuilder for the B0 histogram x ranges can be truncated #5

Open
brianlangseth-NOAA opened this issue Apr 12, 2024 · 0 comments

Comments

@brianlangseth-NOAA
Copy link
Contributor

brianlangseth-NOAA commented Apr 12, 2024

Rebuilder outputs x and y values to make a histogram for B0 values (#B0_dist in res.csv). The range of the x values for this output is set internally. When including alternative starting conditions (when "# Conduct projections with multiple starting values" equals yes) Ive noticed that the x range of potential outputs for B0 can be truncated. This means that multiple unique B0 values can be bunched up at the ends of the range of x values for the histogram. This results in a stacking of multiple unique B0 values. This makes the results appear incorrect, but based on some tests and looking at the histograms for Tmin-Yinit and Tmax-Yinit, which are also rebuilder output, the B0 histogram appears correct, just reported out with a poor range for the x values.

The fix to this would be to go into the fortran code for rebuilder, and confirm the issue. I am not currently planning to do that, as thus far it seems to be a reporting issue and not an actual bug. Im noting this issue here in hopes it may help others who notice this as well.

brianlangseth-NOAA added a commit that referenced this issue Apr 12, 2024
*Fix recovery plot plotting and scale
*Add explanation for B0 histogram issue #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant