내 반려동물 수정 / 삭제 API를 추가합니다. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barabobBOB
reviewed
Apr 14, 2024
cmd/server/router.go
Outdated
Comment on lines
111
to
112
| userApiGroup.PUT("/me/pets/{petID}", userHandler.UpdateMyPet) | ||
| userApiGroup.DELETE("/me/pets/{petID}", userHandler.DeleteMyPet) |
There was a problem hiding this comment.
echo docs 공식문서에는 :petID으로 선언해야 Param으로 값을 가져올 수 있는 걸로 알고 있는데, {petID} 으로 선언해도 문제가 없나요?
There was a problem hiding this comment.
제 환경에서 테스트 했을 때, {petID}인 경우, 405 에러가 계속 반환되는데 승준님 환경에서는 문제가 없는건가요?
(:petID 했을 때는 잘 되네용)
litsynp
force-pushed
the
feat/update-and-delete-my-pet
branch
from
588c2c5 to
8ea9d30
Compare
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내 반려동물 수정 / 삭제 API를 추가합니다.
PUT /users/me/pets/{petID}: 내 반려동물 수정DELETE /users/me/pets/{petID}: 내 반려동물 삭제추가로 Pet 요청(
pet/request.go로 분리) 및UserService테스트 코드 리팩터링합니다.* 버전업 0.11.0 -> 0.12.0