Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response 방식을 render.JSON으로 전환합니다. #36

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Response 방식을 render.JSON으로 전환합니다. #36

merged 2 commits into from
Feb 3, 2024

Conversation

litsynp
Copy link
Contributor

@litsynp litsynp commented Feb 3, 2024 •
edited
Loading

Response 방식을 render.JSON으로 전환합니다.

이 과정에서 #31 이 없어지긴 했지만 래퍼 함수를 따로 두면 될 것 같습니다.

추가로:

  • Response를 모두 View로 전환합니다. (3rd party API 제외)
  • Parsing 관련 패키지를 이동합니다. (utils -> pnd)
  • mutation이 필요 없는 service params들을 pointer 대신 value로 변경합니다.

@litsynp litsynp added the refactor Outer changes to codes label Feb 3, 2024
@litsynp litsynp requested a review from barabobBOB February 3, 2024 02:14
@litsynp litsynp self-assigned this Feb 3, 2024
@litsynp
refactor: rename response to view
ea74e9e 
# Conflicts:
#	cmd/server/handler/auth_handler.go
#	cmd/server/handler/user_handler.go
@litsynp
refactor: rename, repackage, and refactor
b83b2c8
barabobBOB
barabobBOB approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@barabobBOB barabobBOB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 :) 기존 방식보다 더 좋아졌네요 ㅎㅎ

Base automatically changed from feat/error-code to main February 3, 2024 16:30
@litsynp
Copy link
Contributor Author

litsynp commented Feb 3, 2024

🙇

@litsynp litsynp merged commit 38e2bc3 into main Feb 3, 2024
1 check passed
@litsynp litsynp deleted the feat/req-res branch February 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barabobBOB barabobBOB barabobBOB approved these changes

Assignees

@litsynp litsynp

Labels
refactor Outer changes to codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litsynp @barabobBOB