에러 핸들링 관련 리팩터링 및 에러 코드를 추가합니다. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litsynp
force-pushed
the
feat/error-code
branch
2 times, most recently
from
62602b1 to
b3521bb
Compare
litsynp
force-pushed
the
feat/error-code
branch
from
b3521bb to
8bd3d80
Compare
barabobBOB
reviewed
Feb 3, 2024
@barabobBOB 앗... 요것은 제 브랜치인데 ㅋㅋㅋ 원래는 크게 상관 없지만 요 브랜치에 의존하는 PR들이 좀 있어서.. 다음엔 따로 PR 파서 진행 부탁드려요! |
|
@litsynp 헉 알겠습니다..! |
|
@barabobBOB 괜찮아요~ 괜찮으면 어프룹 부탁드립니다 🙇 |
barabobBOB
approved these changes
Feb 3, 2024
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
에러 핸들링 관련 리팩터링 및 에러 코드를 추가합니다.
이제 message 외에
code라는 필드를 Error Response로 같이 반환합니다.pnd패키지에서 enum으로 관리합니다.chi/render를 사용하며,
render.Renderer인터페이스를 구현하는 커스텀 에러인AppError를 추가합니다.에러의 정확한 원인에서부터 status code를 유추할 때가 많아 그냥 repository 단부터 AppError를 반환합니다. 좋은 패턴이라고 생각하진 않지만 일단 편의를 위해서... 더 좋은 방향은 추후 생각해보면 좋을 것 같습니다.
database/sql의 PG Error은
FromPGError(err errror)내에서strings.Contains로 처리합니다.