채팅방 내 Plain Text 메시지 발송 시, 저장 로직을 추가합니다. #100
Open
+137
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litsynp
requested changes
Dec 23, 2024
internal/service/chat_service.go
Outdated
| // 채팅 메시지를 저장합니다. | ||
| func (s *ChatService) SaveChatMessage( | ||
| ctx context.Context, userID, roomID uuid.UUID, messageType, content string, | ||
| ) (*chat.Message, *pnd.AppError) { |
There was a problem hiding this comment.
이거 리베이스하면 아마 오류날 거에요. 이렇게 바꿔주시면 작동할 것 같습니다.
Suggested change
| ) (*chat.Message, *pnd.AppError) { | |
| ) (*chat.Message, error) { |
internal/service/chat_service.go
Outdated
| defer tx.Rollback() | ||
|
|
||
| if transactionError != nil { | ||
| return nil, pnd.FromPostgresError(transactionError.Err) |
There was a problem hiding this comment.
여기도 마찬가지
Suggested change
| return nil, pnd.FromPostgresError(transactionError.Err) | |
| return nil, pnd.FromPostgresError(transactionError) |
internal/service/chat_service.go
Outdated
| }) | ||
|
|
||
| if databaseGenError != nil { | ||
| return nil, pnd.FromPostgresError(databaseGenError) |
There was a problem hiding this comment.
여긴 이렇게 바꿔주시면 될 것 같습니다
Suggested change
| return nil, pnd.FromPostgresError(databaseGenError) | |
| return nil, databaseGenError |
internal/service/chat_service.go
Outdated
| return nil, pnd.FromPostgresError(databaseGenError) | ||
| } | ||
|
|
||
| tx.Commit() |
There was a problem hiding this comment.
여긴 lint에서 아마 걸릴 것 같아요. 이렇게 바꾸면 될 듯 합니다
Suggested change
| tx.Commit() | |
| if err := tx.Commit(); err != nil { | |
| return nil, err | |
| } |
|
리베이스하고 빌드 돌리면 아마 fail 날텐데 코멘트 한번 읽어주세요! |
JoeCP17
force-pushed
the
feat/chat-message-save
branch
from
eff57b7 to
d95152e
Compare
|
go lint 라인 수 조정을 진행합니다. 160 -> 180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가내용
go version 변경내용
make build 또는 프로젝트를 열었을 시, 아래와 같은 이슈가 발생했습니다.
Go toolchain not available해당 이슈의 경우 major, minor 버전 명시가 안되어 있을 경우 발생하는 이슈임으로 파악했고 참고했던 링크는 아래와 같습니다.
stack overflow 바로가기
채팅방 메시지 저장
메시지 저장 시, 현재 plain 텍스트는 row가 아래와 같이 저장됨을 확인했습니다.
현재 plain Text 발송 시 저장되고 있는데 미디어쪽도 추가로직 구현을 진행하려 합니다.