TernaryNegated mutator: do properly mutate shorthand ternaries

pestphp · Nov 22, 2023 · 8755451 · 8755451
1 parent 7d33e0c
commit 8755451
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/Mutators/ControlStructures/TernaryNegated.php b/src/Mutators/ControlStructures/TernaryNegated.php
@@ -6,6 +6,7 @@
 
 use Pest\Mutate\Mutators\Abstract\AbstractMutator;
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\Ternary;
 
@@ -28,6 +29,10 @@ public static function nodesToHandle(): array
     public static function mutate(Node $node): Node
     {
         /** @var Ternary $node */
+        if (! $node->if instanceof Expr) {
+            $node->if = $node->cond;
+        }
+
         $node->cond = new BooleanNot($node->cond);
 
         return $node;

diff --git a/tests/Mutators/ControlStructures/TernaryNegatedTest.php b/tests/Mutators/ControlStructures/TernaryNegatedTest.php
@@ -15,3 +15,15 @@
         return !($a > $b) ? 'a' : 'b';
         CODE);
 });
+
+it('mutates a shorthand ternary condition to be negated', function (): void {
+    expect(mutateCode(TernaryNegated::class, <<<'CODE'
+        <?php
+
+        return $a ?: $b;
+        CODE))->toBe(<<<'CODE'
+        <?php
+
+        return !$a ? $a : $b;
+        CODE);
+});