Fix default printer

WIP.md

@@ -29,7 +29,7 @@
 # Backlog Prio 1
 - [ ] Add minimum threshold enforcement
 - [ ] Finish: Disable mutations by annotation
-- [ ] Run mutations in a resonable order: New, Survived, NotCovered, Skipped, Killed (Survived first, if --stop-on-survived or --bail; NotCovered first, if --stop-on-uncovered)
+- [ ] Run mutations in a reasonable order: New, Survived, NotCovered, Skipped, Killed (Survived first, if --stop-on-survived or --bail; NotCovered first, if --stop-on-uncovered)
 - [ ] Log to file
 - [ ] Automatically skip "Arch" tests
 

src/Mutation.php

@@ -20,7 +20,7 @@ class Mutation
     .'mutations';
 
     /**
-     * @param  array{original: string[], modified: string[]}  $diff
+     * @param  array{original: string[], modified: array<int, ?string>}  $diff
      */
     public function __construct(
         public readonly SplFileInfo $file,
@@ -68,7 +68,7 @@ public function modifiedSource(): string
     }
 
     /**
-     * @return array{original: string[], modified: string[]}
+     * @return array{original: string[], modified: array<int, ?string>}
      */
     private static function diff(Node $originalNode, ?Node $modifiedNode): array
     {
@@ -84,7 +84,7 @@ private static function diff(Node $originalNode, ?Node $modifiedNode): array
     }
 
     /**
-     * @return array{file: string, mutator: string, start_line: int, end_line: int, diff: array{original: string[], modified: string[]}, modified_source_path: string}
+     * @return array{file: string, mutator: string, start_line: int, end_line: int, diff: array{original: string[], modified: array<int, ?string>}, modified_source_path: string}
      */
     public function __serialize(): array
     {
@@ -99,7 +99,7 @@ public function __serialize(): array
     }
 
     /**
-     * @param  array{file: string, mutator: string, start_line: int, end_line: int, diff: array{original: string[], modified: string[]}, modified_source_path: string}  $data
+     * @param  array{file: string, mutator: string, start_line: int, end_line: int, diff: array{original: string[], modified: array<int, ?string>}, modified_source_path: string}  $data
      */
     public function __unserialize(array $data): void
     {

src/Support/Printers/DefaultPrinter.php

@@ -142,11 +142,11 @@ private function writeMutationTestSummary(MutationTest $test): void
 
         $diff = '';
         foreach ($test->mutation->diff['modified'] as $line) {
-            $line = htmlentities($line); // TODO: this is not good, but currently required other printer breaks on `$this->foo()` because of the >
+            $line = htmlentities((string) $line); // TODO: this is not good, but currently required, otherwise printer breaks on `$this->foo()` because of the >
             $diff .= "<div class='text-green'>+ {$line}</div>";
         }
         foreach ($test->mutation->diff['original'] as $line) {
-            $line = htmlentities($line); // TODO: this is not good, but currently required other printer breaks on `$this->foo()` because of the >
+            $line = htmlentities($line); // TODO: this is not good, but currently required, otherwise printer breaks on `$this->foo()` because of the >
             $diff .= "<div class='text-red'>- {$line}</div>";
         }