Refactor profiles to configurations and ensure arguments are merge in…

… the correct order.
pestphp · Nov 8, 2023 · 06f3e17 · 06f3e17
1 parent 33f8cdb
commit 06f3e17
Show file tree

Hide file tree

Showing 25 changed files with 425 additions and 421 deletions.
diff --git a/src/Contracts/ProfileFactory.php → src/Contracts/Configuration.php b/src/Contracts/ProfileFactory.php → src/Contracts/Configuration.php
@@ -4,7 +4,7 @@
 
 namespace Pest\Mutate\Contracts;
 
-interface ProfileFactory
+interface Configuration
 {
     /**
      * @param  array<int, string>|string  ...$paths

diff --git a/src/Contracts/MutationTestRunner.php b/src/Contracts/MutationTestRunner.php
@@ -4,11 +4,9 @@
 
 namespace Pest\Mutate\Contracts;
 
-use Pest\Mutate\Factories\ProfileFactory;
-
 interface MutationTestRunner
 {
-    public function enable(string $profile): void;
+    public function enable(): void;
 
     public function isEnabled(): bool;
 
@@ -19,9 +17,5 @@ public function setOriginalArguments(array $arguments): void;
 
     public function isCodeCoverageRequested(): bool;
 
-    public function getProfileFactory(): ProfileFactory;
-
-    public function getEnabledProfile(): ?string;
-
     public function run(): void;
 }
diff --git a/src/Decorators/TestCallDecorator.php b/src/Decorators/TestCallDecorator.php
@@ -4,19 +4,22 @@
 
 namespace Pest\Mutate\Decorators;
 
+use Pest\Mutate\Contracts\Configuration;
 use Pest\Mutate\Contracts\MutationTestRunner;
-use Pest\Mutate\Factories\ProfileFactory;
-use Pest\Mutate\Profile;
+use Pest\Mutate\Repositories\ConfigurationRepository;
+use Pest\Mutate\Support\Configuration\TestConfiguration;
 use Pest\Mutate\Tester\MutationTestRunnerFake;
 use Pest\PendingCalls\TestCall;
 use Pest\Plugins\Only;
 use Pest\Support\Container;
 
 // @codeCoverageIgnoreStart
-class TestCallDecorator implements \Pest\Mutate\Contracts\ProfileFactory
+class TestCallDecorator implements Configuration
 {
     private MutationTestRunner $testRunner;
 
+    private TestConfiguration $configuration;
+
     public function __construct(private readonly TestCall $testCall)
     {
     }
@@ -31,16 +34,24 @@ public function __call(string $name, array $arguments): TestCall
 
     public function mutate(string $profile = 'default'): self
     {
-        if (! str_starts_with($profile, Profile::FAKE)) {
+        if (! str_starts_with($profile, ConfigurationRepository::FAKE)) {
             Only::enable($this->testCall);
 
             $this->testRunner = Container::getInstance() // @phpstan-ignore-line
                 ->get(MutationTestRunner::class);
+
+            Container::getInstance()->get(ConfigurationRepository::class)->setProfile($profile); // @phpstan-ignore-line
+
+            $this->configuration = Container::getInstance()->get(ConfigurationRepository::class) // @phpstan-ignore-line
+                ->testConfiguration;
         } else {
             $this->testRunner = new MutationTestRunnerFake();
+
+            $this->configuration = Container::getInstance()->get(ConfigurationRepository::class) // @phpstan-ignore-line
+                ->fakeTestConfiguration($profile);
         }
 
-        $this->testRunner->enable($profile); // @phpstan-ignore-line
+        $this->testRunner->enable(); // @phpstan-ignore-line
 
         $this->coveredOnly();
 
@@ -49,14 +60,14 @@ public function mutate(string $profile = 'default'): self
 
     public function coveredOnly(bool $coveredOnly = true): self
     {
-        $this->_profileFactory()->coveredOnly($coveredOnly);
+        $this->configuration->coveredOnly($coveredOnly);
 
         return $this;
     }
 
     public function min(float $minMSI): self
     {
-        $this->_profileFactory()->min($minMSI);
+        $this->configuration->min($minMSI);
 
         return $this;
     }
@@ -66,7 +77,7 @@ public function min(float $minMSI): self
      */
     public function path(array|string ...$paths): self
     {
-        $this->_profileFactory()->path(...$paths);
+        $this->configuration->path(...$paths);
 
         return $this;
     }
@@ -76,14 +87,14 @@ public function path(array|string ...$paths): self
      */
     public function mutator(string|array ...$mutators): self
     {
-        $this->_profileFactory()->mutator(...$mutators);
+        $this->configuration->mutator(...$mutators);
 
         return $this;
     }
 
     public function parallel(bool $parallel = true): self
     {
-        $this->_profileFactory()->parallel($parallel);
+        $this->configuration->parallel($parallel);
 
         return $this;
     }
@@ -93,14 +104,9 @@ public function parallel(bool $parallel = true): self
      */
     public function class(string|array ...$classes): self
     {
-        $this->_profileFactory()->class(...$classes);
+        $this->configuration->class(...$classes);
 
         return $this;
     }
-
-    private function _profileFactory(): ProfileFactory
-    {
-        return $this->testRunner->getProfileFactory();
-    }
 }
 // @codeCoverageIgnoreEnd
diff --git a/src/Functions.php b/src/Functions.php
@@ -2,7 +2,9 @@
 
 declare(strict_types=1);
 
-use Pest\Mutate\Factories\ProfileFactory;
+use Pest\Mutate\Repositories\ConfigurationRepository;
+use Pest\Mutate\Support\Configuration\GlobalConfiguration;
+use Pest\Support\Container;
 
 // @codeCoverageIgnoreStart
 if (! function_exists('mutate')) {
@@ -11,8 +13,8 @@
     /**
      * Returns a factory to configure the mutation testing profile.
      */
-    function mutate(string $profile = 'default'): ProfileFactory
+    function mutate(string $profile = 'default'): GlobalConfiguration
     {
-        return new ProfileFactory($profile);
+        return Container::getInstance()->get(ConfigurationRepository::class)->globalConfiguration($profile); // @phpstan-ignore-line
     }
 }
diff --git a/src/MutationTest.php b/src/MutationTest.php
@@ -6,6 +6,7 @@
 
 use Pest\Mutate\Event\Facade;
 use Pest\Mutate\Plugins\Mutate;
+use Pest\Mutate\Support\Configuration\Configuration;
 use Pest\Mutate\Support\MutationTestResult;
 use Symfony\Component\Process\Exception\ProcessTimedOutException;
 use Symfony\Component\Process\Process;
@@ -32,7 +33,7 @@ public function updateResult(MutationTestResult $result): void
      * @param  array<string, array<int, array<int, string>>>  $coveredLines
      * @param  array<int, string>  $originalArguments
      */
-    public function run(array $coveredLines, Profile $profile, array $originalArguments): void
+    public function run(array $coveredLines, Configuration $configuration, array $originalArguments): void
     {
         /** @var string $tmpfname */
         $tmpfname = tempnam('/tmp', 'pest_mutation_');
@@ -62,7 +63,7 @@ public function run(array $coveredLines, Profile $profile, array $originalArgume
                 ...$originalArguments,
                 '--bail',
                 '--filter="'.implode('|', $filters).'"',
-                $profile->parallel ? '--parallel' : '',
+                $configuration->parallel ? '--parallel' : '',
             ],
             env: [
                 Mutate::ENV_MUTATION_TESTING => $this->mutation->file->getRealPath(),

diff --git a/src/Options/CoveredOnlyOption.php b/src/Options/CoveredOnlyOption.php
@@ -23,6 +23,6 @@ public static function match(string $argument): bool
 
     public static function inputOption(): InputOption
     {
-        return new InputOption('--covered-only', null, InputOption::VALUE_OPTIONAL, '');
+        return new InputOption(sprintf('--%s', self::ARGUMENT), null, InputOption::VALUE_OPTIONAL, '');
     }
 }
diff --git a/src/Options/MutateOption.php b/src/Options/MutateOption.php
@@ -23,6 +23,6 @@ public static function match(string $argument): bool
 
     public static function inputOption(): InputOption
     {
-        return new InputOption('--mutate', null, InputOption::VALUE_OPTIONAL, '');
+        return new InputOption(sprintf('--%s', self::ARGUMENT), null, InputOption::VALUE_OPTIONAL, '');
     }
 }
diff --git a/src/Plugins/Mutate.php b/src/Plugins/Mutate.php
@@ -11,25 +11,10 @@
 use Pest\Mutate\Boostrappers\BootPhpUnitSubscribers;
 use Pest\Mutate\Boostrappers\BootSubscribers;
 use Pest\Mutate\Contracts\MutationTestRunner;
-use Pest\Mutate\Contracts\Printer;
-use Pest\Mutate\Factories\ProfileFactory;
-use Pest\Mutate\Options\ClassOption;
-use Pest\Mutate\Options\CoveredOnlyOption;
-use Pest\Mutate\Options\MinMsiOption;
-use Pest\Mutate\Options\MutateOption;
-use Pest\Mutate\Options\MutatorsOption;
-use Pest\Mutate\Options\ParallelOption;
-use Pest\Mutate\Options\PathsOption;
-use Pest\Mutate\Profile;
-use Pest\Mutate\Support\Printers\CompactPrinter;
-use Pest\Mutate\Support\Printers\DefaultPrinter;
+use Pest\Mutate\Repositories\ConfigurationRepository;
 use Pest\Plugins\Concerns\HandleArguments;
-use Pest\Plugins\Parallel;
 use Pest\Support\Container;
 use Pest\Support\Coverage;
-use Symfony\Component\Console\Input\ArgvInput;
-use Symfony\Component\Console\Input\InputDefinition;
-use Symfony\Component\Console\Output\OutputInterface;
 
 /**
  * @internal
@@ -44,16 +29,6 @@ class Mutate implements Bootable, HandlesArguments
 
     final public const ENV_MUTATION_FILE = 'PEST_MUTATION_FILE';
 
-    private const OPTIONS = [
-        MutateOption::class,
-        PathsOption::class,
-        MutatorsOption::class,
-        MinMsiOption::class,
-        CoveredOnlyOption::class,
-        ParallelOption::class,
-        ClassOption::class,
-    ];
-
     /**
      * The Kernel bootstrappers.
      *
@@ -68,8 +43,7 @@ class Mutate implements Bootable, HandlesArguments
      * Creates a new Plugin instance.
      */
     public function __construct(
-        private readonly Container $container,
-        private readonly OutputInterface $output
+        private readonly Container $container
     ) {
         //
     }
@@ -99,26 +73,17 @@ public function handleArguments(array $arguments): array
         /** @var \Pest\Mutate\Tester\MutationTestRunner $mutationTestRunner */
         $mutationTestRunner = Container::getInstance()->get(MutationTestRunner::class);
 
-        $filteredArguments = ['vendor/bin/pest'];
-        $inputOptions = [];
-        foreach ($arguments as $key => $argument) {
-            foreach (self::OPTIONS as $option) {
-                if ($option::match($argument)) {
-                    $filteredArguments[] = $argument;
-                    $inputOptions[] = $option::inputOption();
-
-                    if ($option::remove()) {
-                        unset($arguments[$key]);
-                    }
-                }
-            }
-        }
+        if (array_filter($arguments, fn (string $argument): bool => str_starts_with($argument, '--mutate=') || $argument === '--mutate') === []) {
+            $mutationTestRunner->setOriginalArguments($arguments);
 
-        $originalArguments = $arguments;
+            return $arguments;
+        }
 
-        $inputDefinition = new InputDefinition($inputOptions);
+        $arguments = Container::getInstance()->get(ConfigurationRepository::class) // @phpstan-ignore-line
+            ->cliConfiguration->fromArguments($arguments);
 
-        $input = new ArgvInput($filteredArguments, $inputDefinition);
+        $mutationTestRunner->enable();
+        $mutationTestRunner->setOriginalArguments($arguments);
 
         // always enable php coverage report, but it will be disabled if not required
         if (Coverage::isAvailable()) {
@@ -129,46 +94,6 @@ public function handleArguments(array $arguments): array
             $arguments[] = '--coverage-php='.Coverage::getPath();
         }
 
-        if (! $input->hasOption(MutateOption::ARGUMENT)) {
-            $mutationTestRunner->setOriginalArguments($originalArguments);
-
-            return $arguments;
-        }
-
-        $profileName = $input->getOption(MutateOption::ARGUMENT) ?? 'default';
-        $profileFactory = new ProfileFactory($profileName); // @phpstan-ignore-line
-
-        if (! str_starts_with((string) $profileName, Profile::FAKE)) { // @phpstan-ignore-line
-            $mutationTestRunner->enable($profileName); // @phpstan-ignore-line
-            $mutationTestRunner->setOriginalArguments($originalArguments);
-        }
-
-        if ($input->hasOption(PathsOption::ARGUMENT)) {
-            $profileFactory->path(explode(',', (string) $input->getOption(PathsOption::ARGUMENT))); // @phpstan-ignore-line
-        }
-
-        if ($input->hasOption(MutatorsOption::ARGUMENT)) {
-            $profileFactory->mutator(explode(',', (string) $input->getOption(MutatorsOption::ARGUMENT))); // @phpstan-ignore-line
-        }
-
-        if ($input->hasOption(MinMsiOption::ARGUMENT)) {
-            $profileFactory->min((float) $input->getOption(MinMsiOption::ARGUMENT)); // @phpstan-ignore-line
-        }
-
-        if ($input->hasOption(CoveredOnlyOption::ARGUMENT)) {
-            $profileFactory->coveredOnly($input->getOption(CoveredOnlyOption::ARGUMENT) !== 'false');
-        }
-
-        if ($input->hasOption(ParallelOption::ARGUMENT)) {
-            unset($arguments[array_search('--'.ParallelOption::ARGUMENT, $arguments, true)]);
-            $profileFactory->parallel();
-            Parallel::disable();
-        }
-
-        if ($input->hasOption(ClassOption::ARGUMENT)) {
-            $profileFactory->class(explode(',', (string) $input->getOption(ClassOption::ARGUMENT))); // @phpstan-ignore-line
-        }
-
         return $arguments;
     }
 }
diff --git a/src/Profile.php b/src/Profile.php