Hotfix/get age #66
Merged
Hotfix/get age #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a system clock. Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Johannestegner
force-pushed
the
hotfix/get-age
branch
from
1121c09 to
b53804d
Compare
rasmusbe
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR does two things:
I'm not 100% sure that we want to document the
clockoption as of now, but seeing it's visible by default in the C# package, I exposed it here as well.Related issue
#65
Motivation
Bugfix motivation is quite obvious, we want the bug fixed!
The ClockInterface part is primarily to make the code easier to test, while allowing the modification of time might be a good feature to expose to the users as well. The Abstraction is in my opinion something that we do want, the visible option I'm less sure about.
Checklist