-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: env management commands #37
Conversation
# Conflicts: # source/commands/login.tsx # source/lib/api.ts
@35C4n0r the lint has some errors.. |
Hey, some functional comments:
|
Please merge from main |
# Conflicts: # .gitignore # package-lock.json # package.json
Hey, @35C4n0r, the |
@gemanor, pushed a change that fixes the issue, It now handles the case when |
@35C4n0r, the scope is redundnat (just use the default), and the description/strategy should be also in the wizard, not only as variables |
@gemanor done! |
The tests are failing now. Also, the success message is missing from the copy command. |
There are also many linting warning. Please ensure you're fixing the useEffect dependencies problems. Just use the standard practices like useCallback/useMemo and pure functions to avoid such. |
@gemanor fixed the error |
As for the warnings, if I don't want something to be the dependency of a useEffect, why should I add it in the dependency array? |
@gemanor, fixed the warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Appreciate the effort!
Please address the comments and attach a sanity test video for the following flows after addressing them)
- Environment copy
- To new one with a wizard
- To a new one with variables provided (all provided, and partially provided - see CR)
- To an existing environment that exists
- To an existing environment that does not exist (fail)
- Invite member
- With organization-level key
- With project-level key
- With wrong key
- With environment-level key
- With provided project/environment variables (see CR)
- With an email that is already a member
- Environment select
- With all optional values as variables
- Login flow on Windows (you said something about the port?)
@35C4n0r any updates on that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
Closes #18
/claim #18